Upgrade websocket connection after completed response#586
Merged
normanmaurer merged 1 commit intonetty:masterfrom Sep 9, 2012
sprsquish:fix-websocket-teardown
Merged
Upgrade websocket connection after completed response#586normanmaurer merged 1 commit intonetty:masterfrom sprsquish:fix-websocket-teardown
normanmaurer merged 1 commit intonetty:masterfrom
sprsquish:fix-websocket-teardown
Conversation
Channel handlers above the HttpEncoder may delay the repsonse being written to the socket. We need to wait for the response to complete before upgrading the pipeline.
Member
|
Should we apply to v3 as well? |
Contributor
Author
|
I think so, yes. Should I open a second pull request after this one is accepted? |
Member
|
Yes please. Just wait for @normanmaurer or @trustin to check it. It looks good to me. |
normanmaurer
added a commit
that referenced
this pull request
Sep 9, 2012
Upgrade websocket connection after completed response
Member
|
@sprsquish thanks for this! Would be perfect if you could also issue a pull-request for v3. |
normanmaurer
added a commit
that referenced
this pull request
Sep 9, 2012
… for the websocket upgrade. See #586
Member
|
@sprsquish I made one modification to move all of the parts of the upgrade to the listener. Please review: |
Contributor
Author
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Apr 2, 2025
…s it is not needed anymore (netty#586) Motivation: Recently GraalVM added support for Apple M1. Modifications: - Remove the comment from resource-config.json file - Update the version for native-maven-plugin Result: The comment in resource-config.json is not needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel handlers above the HttpEncoder may delay the repsonse being
written to the socket. We need to wait for the response to complete
before upgrading the pipeline.