Upgrade connection after completed response#589
Merged
normanmaurer merged 1 commit intonetty:3from Sep 9, 2012
sprsquish:upgrading-websocket-connections
Merged
Upgrade connection after completed response#589normanmaurer merged 1 commit intonetty:3from sprsquish:upgrading-websocket-connections
normanmaurer merged 1 commit intonetty:3from
sprsquish:upgrading-websocket-connections
Conversation
Channel handlers above the HttpEncoder may delay the repsonse being written to the socket. We need to wait for the response to complete before upgrading the pipeline.
normanmaurer
added a commit
that referenced
this pull request
Sep 9, 2012
Upgrade connection after completed response
Member
|
Thanks again ! |
Member
|
Thanks. I've also run the changes against the AutoBahn test cases and everything passes. No big changes in performance. |
Closed
chrisvest
pushed a commit
to chrisvest/netty
that referenced
this pull request
Apr 2, 2025
Motivation: We should run our testsuite with '-Xcheck:jni' to ensure we catch bugs in our JNI code which could later cause issues like crashes Modifications: - Add -Xcheck:jni - Add -ea Result: Testsuite will be able to catch more JNI bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel handlers above the HttpEncoder may delay the repsonse being
written to the socket. We need to wait for the response to complete
before upgrading the pipeline.