Improve flaky NioSocketChannelTest#16679
Merged
Merged
Conversation
Motivation: We've seen IllegalReferenceCountException from this test. This is probably not the root cause, but the root looks like it is lost in the pipeline. Modification: - Increase the test timeouts. - Add sync() calls so we make sure to wait for the event loop shutdowns to complete, before we close the scope of the LeakPresenceDetector. - Change an assertNotSame call in a future listener (which runs on the event loop) with code that captures the error and funnels it out to the test code through a future. Result: More debuggable test, maybe more stable too.
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
Member
|
Port for 4.1 #16681 |
Member
Author
|
5.0 port #16684 |
normanmaurer
added a commit
that referenced
this pull request
Apr 23, 2026
Motivation: We've seen IllegalReferenceCountException from this test. This is probably not the root cause, but the root looks like it is lost in the pipeline. Modification: - Increase the test timeouts. - Add sync() calls so we make sure to wait for the event loop shutdowns to complete, before we close the scope of the LeakPresenceDetector. - Change an assertNotSame call in a future listener (which runs on the event loop) with code that captures the error and funnels it out to the test code through a future. Result: More debuggable test, maybe more stable too. --------- Co-authored-by: Chris Vest <christianvest_hansen@apple.com>
normanmaurer
pushed a commit
that referenced
this pull request
Apr 23, 2026
Motivation: 5.0 port of #16679 Modification: - Increase the test timeouts. - Add sync() calls so we make sure to wait for the event loop shutdowns to complete, before we close the scope of the LeakPresenceDetector. Result: More debuggable test, maybe more stable too. (cherry picked from commit 82a1f0e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
We've seen IllegalReferenceCountException from this test. This is probably not the root cause, but the root looks like it is lost in the pipeline.
Modification:
Result:
More debuggable test, maybe more stable too.