Skip to content

Improve flaky NioSocketChannelTest (#16679)#16684

Merged
normanmaurer merged 1 commit into
netty:5.0from
chrisvest:5.0-flaky-niochannel
Apr 23, 2026
Merged

Improve flaky NioSocketChannelTest (#16679)#16684
normanmaurer merged 1 commit into
netty:5.0from
chrisvest:5.0-flaky-niochannel

Conversation

@chrisvest

@chrisvest chrisvest commented Apr 22, 2026

Copy link
Copy Markdown
Member

Motivation:
5.0 port of #16679

Modification:

  • Increase the test timeouts.
  • Add sync() calls so we make sure to wait for the event loop shutdowns to complete, before we close the scope of the LeakPresenceDetector.

Result:
More debuggable test, maybe more stable too.

(cherry picked from commit 82a1f0e)

Motivation:
We've seen IllegalReferenceCountException from this test. This is
probably not the root cause, but the root looks like it is lost in the
pipeline.

Modification:
- Increase the test timeouts.
- Add sync() calls so we make sure to wait for the event loop shutdowns
to complete, before we close the scope of the LeakPresenceDetector.
- Change an assertNotSame call in a future listener (which runs on the
event loop) with code that captures the error and funnels it out to the
test code through a future.

Result:
More debuggable test, maybe more stable too.

(cherry picked from commit 82a1f0e)
@chrisvest chrisvest added this to the 5.0.0.Final milestone Apr 22, 2026
@normanmaurer normanmaurer merged commit 2048dca into netty:5.0 Apr 23, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants