Add maxFrameLength support to ProtobufVarint32FrameDecoder#16633
Merged
normanmaurer merged 3 commits intoApr 16, 2026
Conversation
1e753d8 to
6967eb0
Compare
normanmaurer
approved these changes
Apr 14, 2026
…rotobufVarint32FrameDecoder.java
Member
|
@fru1tworld did you sign our ICLA already ? https://netty.io/s/icla ? |
chrisvest
approved these changes
Apr 15, 2026
Contributor
Author
|
Yes, I've just signed the ICLA. Thank you! |
Contributor
|
Auto-port PR for 4.1: #16658 |
netty-project-bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Motivation `ProtobufVarint32FrameDecoder` has no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory. ## Modification - Add `maxFrameLength` constructor parameter - When a frame exceeds `maxFrameLength`, skip the frame bytes and throw `TooLongFrameException` - Default constructor remains backward-compatible (`maxFrameLength = Integer.MAX_VALUE`) ## Result Oversized protobuf frames are now rejected with `TooLongFrameException` instead of causing unbounded memory allocation. --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com> (cherry picked from commit 6ab2d86)
netty-project-bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Motivation `ProtobufVarint32FrameDecoder` has no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory. ## Modification - Add `maxFrameLength` constructor parameter - When a frame exceeds `maxFrameLength`, skip the frame bytes and throw `TooLongFrameException` - Default constructor remains backward-compatible (`maxFrameLength = Integer.MAX_VALUE`) ## Result Oversized protobuf frames are now rejected with `TooLongFrameException` instead of causing unbounded memory allocation. --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com> (cherry picked from commit 6ab2d86)
Contributor
|
Auto-port PR for 5.0: #16659 |
Contributor
|
Could not create auto-port PR. |
Contributor
|
Could not create auto-port PR. |
chrisvest
pushed a commit
that referenced
this pull request
Apr 17, 2026
…oder (#16658) Auto-port of #16633 to 4.1 Cherry-picked commit: 6ab2d86 --- ## Motivation `ProtobufVarint32FrameDecoder` has no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory. ## Modification - Add `maxFrameLength` constructor parameter - When a frame exceeds `maxFrameLength`, skip the frame bytes and throw `TooLongFrameException` - Default constructor remains backward-compatible (`maxFrameLength = Integer.MAX_VALUE`) ## Result Oversized protobuf frames are now rejected with `TooLongFrameException` instead of causing unbounded memory allocation. --------- Co-authored-by: fru1tworld <127650598+fru1tworld@users.noreply.github.com> Co-authored-by: Norman Maurer <norman_maurer@apple.com>
chrisvest
pushed a commit
that referenced
this pull request
Apr 18, 2026
…oder (#16659) Auto-port of #16633 to 5.0 Cherry-picked commit: 6ab2d86 --- ## Motivation `ProtobufVarint32FrameDecoder` has no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory. ## Modification - Add `maxFrameLength` constructor parameter - When a frame exceeds `maxFrameLength`, skip the frame bytes and throw `TooLongFrameException` - Default constructor remains backward-compatible (`maxFrameLength = Integer.MAX_VALUE`) ## Result Oversized protobuf frames are now rejected with `TooLongFrameException` instead of causing unbounded memory allocation. --------- Co-authored-by: fru1tworld <127650598+fru1tworld@users.noreply.github.com> Co-authored-by: Norman Maurer <norman_maurer@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ProtobufVarint32FrameDecoderhas no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory.Modification
maxFrameLengthconstructor parametermaxFrameLength, skip the frame bytes and throwTooLongFrameExceptionmaxFrameLength = Integer.MAX_VALUE)Result
Oversized protobuf frames are now rejected with
TooLongFrameExceptioninstead of causing unbounded memory allocation.