Auto-port 5.0: Add maxFrameLength support to ProtobufVarint32FrameDecoder#16659
Merged
Conversation
## Motivation `ProtobufVarint32FrameDecoder` has no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory. ## Modification - Add `maxFrameLength` constructor parameter - When a frame exceeds `maxFrameLength`, skip the frame bytes and throw `TooLongFrameException` - Default constructor remains backward-compatible (`maxFrameLength = Integer.MAX_VALUE`) ## Result Oversized protobuf frames are now rejected with `TooLongFrameException` instead of causing unbounded memory allocation. --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com> (cherry picked from commit 6ab2d86)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16633 to 5.0
Cherry-picked commit: 6ab2d86
Motivation
ProtobufVarint32FrameDecoderhas no protection against oversized frames. A malicious client can send a large varint length value and cause the server to allocate excessive memory.Modification
maxFrameLengthconstructor parametermaxFrameLength, skip the frame bytes and throwTooLongFrameExceptionmaxFrameLength = Integer.MAX_VALUE)Result
Oversized protobuf frames are now rejected with
TooLongFrameExceptioninstead of causing unbounded memory allocation.