Remove api from the io.netty5.buffer.api package path#12792
Merged
Conversation
64f0d21 to
3cc3cef
Compare
Motivation: The `api` component is a holdover from before the package rename from `io.netty` to `io.netty5`, and from before `ByteBuf` was removed. So this was originally meant to separate the new code from the old. But since we did the package rename, and we removed `ByteBuf`, this is no longer necessary. Modification: Remove `api` from the package path and update... everything... to match. Result: Buffers are now in a package path more in line with the naming convention in the rest of Netty.
3cc3cef to
1309918
Compare
violetagg
added a commit
to violetagg/socks-proxy
that referenced
this pull request
Sep 11, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to violetagg/codec-haproxy
that referenced
this pull request
Sep 11, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to violetagg/codec-extras
that referenced
this pull request
Sep 11, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 Modification: - Adapt to the changed package for Buffer API Result: Project build is green again
violetagg
added a commit
to netty-contrib/codec-extras
that referenced
this pull request
Sep 12, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 Modification: - Adapt to the changed package for Buffer API Result: Project build is green again
violetagg
added a commit
to netty-contrib/codec-haproxy
that referenced
this pull request
Sep 12, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to netty-contrib/socks-proxy
that referenced
this pull request
Sep 12, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
apicomponent is a holdover from before the package rename fromio.nettytoio.netty5, and from beforeByteBufwas removed. So this was originally meant to separate the new code from the old. But since we did the package rename, and we removedByteBuf, this is no longer necessary.Modification:
Remove
apifrom the package path and update... everything... to match.Result:
Buffers are now in a package path more in line with the naming convention in the rest of Netty.
Reviewer note: Except for deleting the spare
package-info.javafile, the refactoring was done entirely mechanically by IntelliJ. If the build passes, I'm just going to merge this.