Move native-image metadata from src/main/resources/native-image/ to src/main/resources/META-INF/native-image/#12786
Merged
chrisvest merged 1 commit intoSep 9, 2022
Conversation
src/main/resources/native-image/ to src/main/resources/META-INF/native-image/
chrisvest
approved these changes
Sep 9, 2022
Member
|
Thanks |
Contributor
Author
|
Thank you for reviewing and merging this PR! :) |
violetagg
added a commit
to violetagg/socks-proxy
that referenced
this pull request
Sep 11, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to violetagg/codec-haproxy
that referenced
this pull request
Sep 11, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to netty-contrib/codec-haproxy
that referenced
this pull request
Sep 12, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
violetagg
added a commit
to netty-contrib/socks-proxy
that referenced
this pull request
Sep 12, 2022
Motivation: - Buffer API package was changed from `io.netty5.buffer.api` to `io.netty5.buffer` netty/netty#12792 - Small enhancement was introduced to `ChannelHandlerMetadataUtil` netty/netty#12786 Modification: - Adapt to the changed package for Buffer API - Adapt to the change in `ChannelHandlerMetadataUtil` Result: Project build is green again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
#12738 introduced automatic metadata generation for handlers. However, @violetagg rightly noticed that this metadata was not under META-INF. This means it wouldn't automatically be picked up by the native-image builder. This slipped through testing as I was manually merging the metadata before sending it over for tests with an existing Netty version.
Modification:
Move all generated
reflect-config.jsonfiles fromsrc/main/resources/native-image/...tosrc/main/resources/META-INF/native-image/Result:
Native-image will properly pick up the generated handler metadata