-
-
Notifications
You must be signed in to change notification settings - Fork 221
bar.css, bluescreen.css: fixed leaks of page's default CSS into Tracy #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
On this note, I would really love if bar.css 's could be changed to: I make this change every time there is an update so I can include ACE editor in a custom panel. I have mentioned this before, but was hoping that if some css changes are about to be made that this could be reconsidered. Thanks and sorry for hijacking! |
|
Since |
I just tested with your changes and I still need to make that change of mine which makes things much easier to override. My issue is actually kind of the reverse to what you are addressing here - sorry for the confusion - I just wanted to get the CSS discussion going again. More info here: #151 |
|
Just thought I'd also post the additional CSS rules I am adding (along with that change from The highlighted lines are the ones relevant to all Tracy installs. The rest are only relevant to some of my custom panels. This combination seems to work well, but perhaps your additions here would avoid the need for some of my added rules? |
|
So basically, your problem is that Tracy's style is damaging something you've put inside the panel? I fixed issues occurring when outside page's CSS damages Tracy's design. I believe these are two different things and should be solved separately. Your problem is primarily in the third party library you are using and there it should be fixed. Maybe it can be fixed in Tracy but, as I said, it is different problem. However, for test purpose, I've just tried to change |
Yes, I realize the difference. I was just trying to contribute to improving the CSS conflicts in both directions. Anyway, sorry for hijacking your PR. |
|
Thanks! |
|
I merged only :before and :after reset, for the |
| #tracy-debug *:before, | ||
| #tracy-debug *:after { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO all: unset; is better


I just made Tracy more sexy :) There is issue opened that shows headings being affected by CSS property with
!importantset on. I have fixed this particular case (for headings and paragraphs).Another problem occured on page with styled pseudoelements
:beforeor:after. On my page, there are styled headings that are decorated by these pseudoelements. Sadly, Tracy rendered these as well and so its layout went broken. Now, after my fixes, any pseudoelements inside Tracy will be hidden by default except cases where it is need for it.