-
-
Notifications
You must be signed in to change notification settings - Fork 221
All css rules are !important [WIP] #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm afraid that this is going to break a lot of stuff. |
|
It should not… Anyway it is targeted to the next bigger release. |
|
With panels I use, it seems to be OK. But also I think that many panels that use a lot of CSS would have serious problems after this change. For example, for the guy who commented my last PR it could be very problematic. But, as I said in my PR, I think this is not primarily problem of Tracy but the third-party libraries integrated into it. Please consider to reset |
|
It automatically appends Yes, it completely breaks injection of web styles to Tracy, but it's purpose. |
|
@vlastavesely done ec3380b |
a6e9626 to
6d9d48a
Compare
c23b071 to
28b7018
Compare
Being that guy :) I can say that I agree that this is very problematic. I have been playing around with this PR and it looks like it makes it impossible to style any custom panels using an external stylesheet. This is something I do with many of my panels. Now the only way to override the !important is to use inline styles also with an important. I know I keep harping on it, but changing |
|
The problem is that Tracy (panels and bar) must not be accidentally affected by website CSS style. The only way to prevent that (until browsers will support revert) is to reset all important CSS properites. For bar, for panels. This PR resets them in very hard way. On the other side, there is need to create custom styles for custom panels. It is absolutely easy. You just need to add This PR would make custom styles only slightly harder, it requires in addition to add |
8d1f977 to
2f4a70d
Compare
2ec5e86 to
52b29ea
Compare
af1e9ce to
66c5d00
Compare
342ef20 to
6d06dc1
Compare
55360f2 to
867c2b6
Compare
a2951f1 to
1116024
Compare
All Tracy CSS rules are
!important, so they cannot be rewriten by styles css of website.