Skip to content

The -o option can be used multiple times No.2 #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milo merged 3 commits into from
Jan 2, 2021
Merged

The -o option can be used multiple times No.2 #329

milo merged 3 commits into from
Jan 2, 2021

Conversation

@milo
Copy link
Member

@milo milo commented Jul 7, 2016

Alternative approach to #310.

@dg
Copy link
Member

dg commented Jul 7, 2016

stdout -> stdoutFormat 👍

options['-o'] -> $this->outputs hmmm, perhaps unnecessary internal dependency…

I compared it on GitHub in phone and it is quite possible that I missed the other differences.

dg
dg reviewed Jul 7, 2016
View reviewed changes
src/Runner/CliTester.php Outdated
-o <console|tap|junit|log|none>
Specify one or more output formats with optional file name.
(e.g. -o junit:output.xml)
-w | --watch <path> Watch directory.
Copy link
Member

@dg dg Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about -o <console|tap|junit|log|none> (e.g. -o junit:output.xml) to save one row?

Copy link
Member Author

@milo milo Jul 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try that.

Copy link
Member Author

@milo milo Jul 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, it looks strange when not aligned.

@milo
Copy link
Member Author

milo commented Jul 7, 2016 •
edited
Loading

options['-o'] -> $this->outputs hmmm, perhaps unnecessary internal dependency…

Yes. That's part I don't like too but I cannot figure how to solve it in other way. Imagine I will call -o console -o tap:output.tap -o junit:output.xml, I would like to:

  • keep ENUM check in CommandLine. So value tap:file.name has to be modified before this check (NORMALIZER do it) and file.name has to be kept somewhere for OutputHandler's constructor. The $this->outputs is used for this. I cannot figure how to keep file.name as a part of $options['-o'] without hidden functionality.
  • prevent more outputs into one file

@milo
Copy link
Member Author

milo commented Jul 8, 2016

@dg Updated

@TomasVotruba
Copy link

TomasVotruba commented Oct 20, 2016

What needs to be done here?

@milo
Copy link
Member Author

milo commented Oct 21, 2016

Not sure. But I'm not satisfied with an implementation.

@TomasVotruba
Copy link

TomasVotruba commented Oct 21, 2016

What could be changed to make you more satisfied?

@milo
Copy link
Member Author

milo commented Oct 21, 2016

That's what I'm nor sure about. The part with NORMALIZER probably. The main purpose for this PR is to allow pass multiple output handlers by CLI arguments. Propose is -o format:file.ext. Maybe another syntax would be better and more straightfoward for implementation.

@dg dg force-pushed the master branch 2 times, most recently from 715ed4e to 334dc33 Compare January 4, 2017 14:23
@dg dg force-pushed the master branch 3 times, most recently from c7e8a12 to df5e87f Compare July 24, 2017 14:21
@dg dg force-pushed the master branch 2 times, most recently from b9711f5 to 3f273cf Compare June 7, 2018 11:24
@milo milo mentioned this pull request Sep 5, 2018
Closed
@milo milo force-pushed the master branch 2 times, most recently from eaaeb7b to 7184606 Compare February 21, 2019 06:47
@dg dg force-pushed the master branch 2 times, most recently from ee525b7 to 6ca248e Compare February 27, 2019 13:34
@dg dg force-pushed the master branch 4 times, most recently from 176965b to 0e20479 Compare November 19, 2019 01:10
milo added a commit to milo/tester that referenced this pull request Jan 2, 2021
@milo
CliTester: option -o is repeatable and accepts file name parameter (n…
46d1f0c 
…ette#329)
milo added a commit to milo/tester that referenced this pull request Jan 2, 2021
@milo
CliTester: option --log replaced by -o log (nette#329)
abc18e7
@milo milo force-pushed the pull-multi-output-v2 branch from a5ae677 to abc18e7 Compare January 2, 2021 21:25
milo added a commit to milo/tester that referenced this pull request Jan 2, 2021
@milo
CliTester: option --log replaced by -o log (nette#329)
f7ae74a
@milo milo force-pushed the pull-multi-output-v2 branch from abc18e7 to f7ae74a Compare January 2, 2021 21:31
@milo milo mentioned this pull request Jan 2, 2021
Closed
@milo milo force-pushed the pull-multi-output-v2 branch from f7ae74a to 12585ef Compare January 2, 2021 21:36
@milo milo merged commit 12585ef into nette:master Jan 2, 2021
milo added a commit that referenced this pull request Jan 3, 2021
@milo
CliTester: option --log replaced by -o log (#329)
2dfa447
dg pushed a commit that referenced this pull request Jan 31, 2021
@milo @dg
CommandLine: added NORMALIZER (#329)
58481ae
dg pushed a commit that referenced this pull request Jan 31, 2021
@milo @dg
CliTester: option -o is repeatable and accepts file name parameter (#329
8571fbc 
)
dg pushed a commit that referenced this pull request Jan 31, 2021
@milo @dg
CliTester: option --log replaced by -o log (#329)
dcfaa76
dg pushed a commit that referenced this pull request Feb 5, 2021
@milo @dg
CommandLine: added NORMALIZER (#329)
33e0a86
dg pushed a commit that referenced this pull request Feb 5, 2021
@milo @dg
CliTester: option -o is repeatable and accepts file name parameter (#329
7946609 
)
dg pushed a commit that referenced this pull request Feb 5, 2021
@milo @dg
CliTester: option --log replaced by -o log (#329)
5b92655
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CommandLine: added NORMALIZER (#329)
57c3ec6
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option -o is repeatable and accepts file name parameter (#329
94f30fa 
)
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option --log replaced by -o log (#329)
30d4b61
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CommandLine: added NORMALIZER (#329)
86c6c94
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option -o is repeatable and accepts file name parameter (#329
6c47556 
)
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option --log replaced by -o log (#329)
a9d11cc
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CommandLine: added NORMALIZER (#329)
11ba395
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option -o is repeatable and accepts file name parameter (#329
d72b1b2 
)
dg pushed a commit that referenced this pull request Mar 1, 2021
@milo @dg
CliTester: option --log replaced by -o log (#329)
7dc3282
@milo milo deleted the pull-multi-output-v2 branch July 21, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

next-bigger-release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@milo @dg @TomasVotruba @vojtech-dobes