Skip to content

Conversation

@milo
Copy link
Member

@milo milo commented May 4, 2016

For example:

vendor/bin/tester -o console -o tap:output.tap -o junit:output.xml -o log:output.log

Tester ASCII art logo is shown, only if output for stdout (without parameter) is not passed.

@dg
Copy link
Member

dg commented May 12, 2016

Would not it be easier to leave CommandLine as is, change parameter to repeatable and split it in loadOptions()?

@milo
Copy link
Member Author

milo commented May 16, 2016

@dg Probably yes. The -o value:file/path syntax seems ok? So, drop CommandLine::ENUM (this is the only one place) and parse it manually. Or add CommandLine::NORMALIZER like:

CommandLine::NORMALIZER => function ($arg) {
    list($value, $path) = explode(':', $arg, 2);
    if (...) throw ...
};

I'll try how it will look like.

@milo milo force-pushed the pull-multi-output branch from 8a68c68 to 1f00c91 Compare May 16, 2016 08:13
@milo
Copy link
Member Author

milo commented May 16, 2016

@dg What about such approach (last commit)?

@dg
Copy link
Member

dg commented May 16, 2016

I tried to find if there is any pattern how should these parameters look, but it seems that this is pole neorané … not standardized. Sometimes it is used this way:

vendor/bin/tester -o console -o tap -file output.tap -o junit -file output.xml -o log -file output.log

Which looks logical, but little bit weird. So syntax is fine for me.

--stop-on-fail Stop execution upon the first failure.
-j <num> Run <num> jobs in parallel (default: 8).
-o <console|tap|junit|log|none>
Specify output format. Repeatable with parameter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify one or more output formats with optional file name is probably better that Repeatable with parameter.

@dg
Copy link
Member

dg commented May 16, 2016

In fact ENUM is used by Tester, try tester --colors x before and after.

@milo
Copy link
Member Author

milo commented May 17, 2016

In fact ENUM is used by Tester, try tester --colors x before and after.

Ups, I was rash. I have to find a way how to preserve console|tap|junit|log|none at one place and do not collide with ENUM implementation. Or replace ENUM implementation by something similarly easy.

@milo milo force-pushed the master branch 2 times, most recently from 20198c1 to 1b583e9 Compare May 19, 2016 09:41
@milo milo added this to the 2.0 milestone Jul 1, 2016
@dg dg force-pushed the master branch 2 times, most recently from 715ed4e to 334dc33 Compare January 4, 2017 14:23
@milo milo modified the milestones: 2.x, 2.0 Jan 8, 2017
@dg dg force-pushed the master branch 3 times, most recently from c7e8a12 to df5e87f Compare July 24, 2017 14:21
@dg dg force-pushed the master branch 2 times, most recently from b9711f5 to 3f273cf Compare June 7, 2018 11:24
@dg dg force-pushed the master branch 2 times, most recently from 37f5151 to c3bd1b2 Compare November 19, 2019 13:19
@dg dg force-pushed the master branch 10 times, most recently from f2dae8a to 20b7c0b Compare January 24, 2020 13:18
@dg dg force-pushed the master branch 3 times, most recently from e9c3f27 to 666cb04 Compare July 13, 2020 13:17
@dg dg force-pushed the master branch 5 times, most recently from 977e96a to dd5bc63 Compare October 15, 2020 20:09
@dg dg force-pushed the master branch 6 times, most recently from 4969211 to 81b3703 Compare November 2, 2020 17:30
@milo
Copy link
Member Author

milo commented Jan 2, 2021

Closing in favour of #329

@milo milo closed this Jan 2, 2021
@milo milo deleted the pull-multi-output branch July 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants