Skip to content

Resolver: Fix undefined and never called spaces. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 2 commits into from
Jul 19, 2019
Merged

Resolver: Fix undefined and never called spaces. #213

dg merged 2 commits into from
Jul 19, 2019

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Fix and basic reimplementation for define type hints in comment section and little code reorganization.

 ------ --------------------------------------------------------------------- 
  Line   DI/Resolver.php                                                      
 ------ --------------------------------------------------------------------- 
  117    Call to an undefined method ReflectionFunctionAbstract::isPublic().  
  117    Variable $refClass might not be defined.                             
  117    Variable $reflection might not be defined.                           
  118    Call to an undefined method ReflectionFunctionAbstract::isStatic().  
  118    Variable $reflection might not be defined.                           
  122    Variable $reflection might not be defined.                           
  124    Variable $reflection might not be defined.                           
  335    Negated boolean expression is always false.                          
 ------ ---------------------------------------------------------------------

@dg dg force-pushed the master branch 4 times, most recently from ad26604 to a37036c Compare July 19, 2019 11:12
@dg dg merged commit 89b7ae6 into nette:master Jul 19, 2019
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
c60c7ff
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
fecd1fb
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
15978c3
@janbarasek janbarasek deleted the janbarasek-resolver branch July 19, 2019 11:32
dg pushed a commit that referenced this pull request Aug 7, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
1a47803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbarasek @dg