Skip to content

InjectExtension: Fix type hint and always executed if. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Jul 19, 2019
Merged

InjectExtension: Fix type hint and always executed if. #210

dg merged 1 commit into from
Jul 19, 2019

Conversation

@janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Fix type error and if condition order:

 ------ ---------------------------------------------------------- 
  Line   DI/Extensions/InjectExtension.php                         
 ------ ---------------------------------------------------------- 
  37     Right side of && is always true.                          
  61     Parameter #4 $container of static method                  
         Nette\DI\Extensions\InjectExtension::checkType() expects  
         Nette\DI\Container|Nette\DI\Resolver|null,                
         Nette\DI\ContainerBuilder|null given.                     
 ------ ----------------------------------------------------------

@dg dg merged commit edf67d2 into nette:master Jul 19, 2019
@dg
Copy link
Member

dg commented Jul 19, 2019

Thanks

dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)
b365d4c
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)
2378ea6
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)
a37036c
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
c60c7ff
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
fecd1fb
dg pushed a commit that referenced this pull request Jul 19, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
15978c3
dg pushed a commit that referenced this pull request Aug 7, 2019
@janbarasek @dg
fixed bugs reported by PhpStan (#212)(#211)(#210)(#208)(#207)(#213)
1a47803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janbarasek @dg