build(windows): vendor xxd.c#36746
Merged
justinmk merged 2 commits intoneovim:masterfrom Nov 30, 2025
Merged
Conversation
Problem: Currently we fetch a prebuilt xxd.exe from neovim/deps for Windows, which is not ideal in terms of obviousness, misses updates, and is clumsy to update. Solution: Similar to tee.c (neovim#36363), vendor xxd.c from Vim and build it as part of the Neovim build process. This makes the source obvious, enables analyzer checks, and simplifies updates. Fixes neovim#36664
justinmk
reviewed
Nov 29, 2025
Member
|
Thanks! Can you run And one other small thing, let's add a trivial test that exercises |
- Reformat list(APPEND ...) to multi-line style for readability - Add functional test for xxd round-trip encoding/decoding
010cdee to
f75083d
Compare
justinmk
reviewed
Nov 30, 2025
| test_deps.dependOn(test_fixture(b, "streams-test", libuv, target, optimize, &flags)); | ||
|
|
||
| // xxd - hex dump utility (vendored from Vim) | ||
| const xxd_exe = b.addExecutable(.{ |
Member
There was a problem hiding this comment.
oh glad you noticed this. i think we forgot to update build.zig for tee ...
(not a blocker for this PR)
justinmk
pushed a commit
to justinmk/neovim
that referenced
this pull request
Nov 30, 2025
backport neovim#36746 Problem: Currently we fetch a prebuilt xxd.exe from neovim/deps for Windows, which is not ideal in terms of obviousness, misses updates, and is clumsy to update. Solution: Similar to tee.c (neovim#36363), vendor xxd.c from Vim and build it as part of the Neovim build process. This makes the source obvious, enables analyzer checks, and simplifies updates. Fixes neovim#36664
This was referenced Nov 30, 2025
Merged
justinmk
added a commit
that referenced
this pull request
Nov 30, 2025
backport #36746 Problem: Currently we fetch a prebuilt xxd.exe from neovim/deps for Windows, which is not ideal in terms of obviousness, misses updates, and is clumsy to update. Solution: Similar to tee.c (#36363), vendor xxd.c from Vim and build it as part of the Neovim build process. This makes the source obvious, enables analyzer checks, and simplifies updates. Fixes #36664 Co-authored-by: benarcher2691 <ben.archer2691@gmail.com>
benarcher2691
added a commit
to benarcher2691/neovim
that referenced
this pull request
Dec 1, 2025
Problem: Currently we fetch a prebuilt xxd.exe from neovim/deps for Windows, which is not ideal in terms of obviousness, misses updates, and is clumsy to update. Solution: Similar to tee.c (neovim#36363), vendor xxd.c from Vim and build it as part of the Neovim build process. This makes the source obvious, enables analyzer checks, and simplifies updates. Fixes neovim#36664
yochem
pushed a commit
to yochem/neovim
that referenced
this pull request
Dec 15, 2025
Problem: Currently we fetch a prebuilt xxd.exe from neovim/deps for Windows, which is not ideal in terms of obviousness, misses updates, and is clumsy to update. Solution: Similar to tee.c (neovim#36363), vendor xxd.c from Vim and build it as part of the Neovim build process. This makes the source obvious, enables analyzer checks, and simplifies updates. Fixes neovim#36664
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xxd.cfrom Vim, similar to howtee.cwas added in fix(windows): restoreteefunctionality on Windows #36363xxdexecutable as part of the Neovim build processxxd.cto lint and format targetsTest plan
xxdbuilds successfullyxxd --versionworksecho test | xxd | xxd -r) worksFixes #36664