-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Labels
buildbuilding and installing Neovim using the provided scriptsbuilding and installing Neovim using the provided scriptscomplexity:lowLow-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.mdLow-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.mddistributionpackaging and distributing Nvim to userspackaging and distributing Nvim to usersplatform:windows
Milestone
Description
Problem
We normally don't include xxd but we do in Windows. Currently we fetch a prebuilt xxd.exe from https://github.com/neovim/deps/blob/master/opt/xxd.exe , but this has the following problems:
- it's not ideal in terms of obviousness
- we are missing some updates to
xxd.csince then - it's clumsy to update stuff in https://github.com/neovim/deps , so we only want to use it as a last resort
#36363 demonstrates that these tiny one-file C sources are easy to vendor, and also have some advantages (analyzer checks). Our build system is also setup to easily build and include third-party vendored things.
Expected behavior
Similar to tee.c #36363 , we can include xxd.c :
https://github.com/vim/vim/blob/77cfc49060a50daefd1675b8a1dece0e6e943384/src/xxd/xxd.c
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buildbuilding and installing Neovim using the provided scriptsbuilding and installing Neovim using the provided scriptscomplexity:lowLow-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.mdLow-risk, self-contained. Do NOT ask "can I work on this", just read CONTRIBUTING.mddistributionpackaging and distributing Nvim to userspackaging and distributing Nvim to usersplatform:windows