Add Atoi/Itoa by shargon · Pull Request #389 · neo-project/neo-devpack-dotnet

shargon · 2020-11-08T09:32:09Z

Sync neo-project/neo#2043
Close #385

Tommo-L · 2020-11-09T11:53:32Z

waiting #387

superboyiii · 2020-11-12T07:54:24Z

Test PASS

using Neo.SmartContract.Framework;
using Neo.SmartContract.Framework.Services.Neo;
using System;
using System.ComponentModel;
using System.Numerics;

namespace Sample
{
    [ManifestExtra("Author", "Neo")]
    [ManifestExtra("Name", "Sample")]
    [ManifestExtra("Email", "dev@neo.org")]
    [ManifestExtra("Description", "This is a contract example")]
    [Features(ContractFeatures.HasStorage)]
    public class Sample : SmartContract
    {
        #region Notifications
        [DisplayName("Put")]
        public static event Action<string> Onput;
        #endregion
        //TODO: Replace it with your own address.
        static readonly byte[] Owner = "NLtDqwnj9s7wQVyaiD5ohjV3e9fUVkZxDp".ToScriptHash();

        private static bool IsOwner() => Runtime.CheckWitness(Owner);

        public static bool Verify() => IsOwner();

        // TODO: Replace it with your methods.
        public static byte[] MyMethod()
        {
            return Storage.Get("Hello");
        }

        public static void Put(string word)
        {
            // It will be executed during deploy
            Storage.Put("Hello", word);
            Runtime.Log("Put " + word + " into storage completely.");
            Onput(word);
        }

        public static void Update(byte[] script, string manifest)
        {
            if (!IsOwner()) throw new Exception("No authorization.");
            Contract.Update(script, manifest);
        }

        public static void Destroy()
        {
            if (!IsOwner()) throw new Exception("No authorization.");
            Contract.Destroy();
        }
    }
}

invoke

{
  "jsonrpc": "2.0",
  "method": "invokefunction",
  "params": [
    "0x0a23fa703f033e4ba663c98ad7a61b1802ca63cd",
    "put",
    [
      {
        "type": "String",
        "value": "world"
      }
    ],
    [
      {
        "account": "NLtDqwnj9s7wQVyaiD5ohjV3e9fUVkZxDp",
        "scopes": "CalledByEntry"
      }
    ]
  ],
  "id": 3
}

Response:

{
    "jsonrpc": "2.0",
    "id": 3,
    "result": {
        "script": "DAV3b3JsZBHADANwdXQMFM1jygIYG6bXisljpks+Az9w+iMKQWJ9W1I=",
        "state": "HALT",
        "gasconsumed": "4274200",
        "exception": null,
        "stack": [
            {
                "type": "Any"
            }
        ],
        "tx": "ALXvdVUYOEEAAAAAAAZREgAAAAAAUxcAAAEKo4e1Ppa3mJpjFDGgVt0fQKBC9gEAKQwFd29ybGQRwAwDcHV0DBTNY8oCGBum14rJY6ZLPgM/cPojCkFifVtSAUIMQL/is98euFokwpfYWqJ4M9U9HX7QhnFe5ocmIL9OvlMRFrfyoKvgjkgqSgwpZmkJBneA1FNqpIcnftG7Aia71fopDCEDzqPi+B8a+TUi0p7eTySh8L7erXKTOR0ziA9Uddl4eMkLQZVEDXg="
    }
}

Console in cli
Runtime.Log("Put " + word + " into storage completely.");

GetApplicationLog

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0xe481e6a496783135616dc57d0839068ab0d2a0282196f4560246215f6dd62a08",
        "trigger": "Application",
        "vmstate": "HALT",
        "gasconsumed": "4274200",
        "stack": [
            {
                "type": "Any"
            }
        ],
        "notifications": [
            {
                "contract": "0x0a23fa703f033e4ba663c98ad7a61b1802ca63cd",
                "eventname": "Put",
                "state": {
                    "type": "Array",
                    "value": [
                        {
                            "type": "ByteString",
                            "value": "d29ybGQ="
                        }
                    ]
                }
            }
        ]
    }
}

superboyiii · 2020-11-12T08:14:52Z

@erikzhang Merge?

Tommo-L · 2020-11-12T08:16:24Z

Conflicts

shargon · 2020-11-12T10:17:10Z

Merge?

superboyiii · 2020-11-13T06:46:23Z

@erikzhang

vncoelho · 2020-11-13T20:25:56Z

@superboyiii,
In your example I got error on these conversions here:

Contract1.cs(20,40): error CS0266: Cannot implicitly convert type 'Neo.UInt160' to 'byte[]'. An explicit conversion exists (are you missing a cast?) [/neo-devpack-dotnet/templates/Template.CSharpNeoCompiler/Template.CSharpNeoCompiler.csproj]
Contract1.cs(22,63): error CS1503: Argument 1: cannot convert from 'byte[]' to 'Neo.UInt160' [/neo-devpack-dotnet/templates/Template.CSharpNeoCompiler/Template.CSharpNeoCompiler.csproj]
    0 Warning(s)
    2 Error(s)

shargon · 2020-11-14T12:08:33Z

@superboyiii your test must be with an integer

public static void Put(string word)
        {
            // It will be executed during deploy
            Storage.Put("Hello", word);
            Runtime.Log("Put " + word + " into storage completely.");
            Onput(word);
        }

superboyiii · 2020-11-16T02:41:55Z

@superboyiii,
In your example I got error on these conversions here:

Contract1.cs(20,40): error CS0266: Cannot implicitly convert type 'Neo.UInt160' to 'byte[]'. An explicit conversion exists (are you missing a cast?) [/neo-devpack-dotnet/templates/Template.CSharpNeoCompiler/Template.CSharpNeoCompiler.csproj]
Contract1.cs(22,63): error CS1503: Argument 1: cannot convert from 'byte[]' to 'Neo.UInt160' [/neo-devpack-dotnet/templates/Template.CSharpNeoCompiler/Template.CSharpNeoCompiler.csproj]
    0 Warning(s)
    2 Error(s)

I saw it was changed recently in 6051662

superboyiii · 2020-11-16T06:34:33Z

@superboyiii your test must be with an integer

public static void Put(string word)
        {
            // It will be executed during deploy
            Storage.Put("Hello", word);
            Runtime.Log("Put " + word + " into storage completely.");
            Onput(word);
        }

Retest: PASS

using Neo;
using Neo.SmartContract.Framework;
using Neo.SmartContract.Framework.Services.Neo;
using System;
using System.ComponentModel;

namespace Sample
{
    [ManifestExtra("Author", "Neo")]
    [ManifestExtra("Name", "Sample")]
    [ManifestExtra("Email", "dev@neo.org")]
    [ManifestExtra("Description", "This is a contract example")]
    public class Sample : SmartContract
    {
        #region Notifications
        [DisplayName("Word")]
        public static event Action<string> Word;

        [DisplayName("InvokePutCount")]
        public static event Action<byte[]> InvokePutCount;
        #endregion
        //TODO: Replace it with your own address.
        static readonly UInt160 Owner = "NLtDqwnj9s7wQVyaiD5ohjV3e9fUVkZxDp".ToScriptHash();

        private static bool IsOwner() => Runtime.CheckWitness(Owner);

        public static bool Verify() => IsOwner();

        // TODO: Replace it with your methods.
        public static byte[] MyMethod()
        {
            return Storage.Get("Hello");
        }

        public static void Put(string word)
        {
            int times = 2;
            // It will be executed during deploy
            Runtime.Log("Invoke Stroage.Put for " + times + " times.");
            Storage.Put("Hello", word);
            if (Storage.Get("No") != null)
            {
                Storage.Put("No", Storage.Get("No").ToBigInteger() + 1);
                
            } else
            {
                Storage.Put("No", 1);
            }
            var num = Storage.Get("No");
            Runtime.Log("Put " + word + " into storage completely");
            Word(word);
            InvokePutCount(num);


        }

        public static void Update(byte[] script, string manifest)
        {
            if (!IsOwner()) throw new Exception("No authorization.");
            Contract.Update(script, manifest);
        }

        public static void Destroy()
        {
            if (!IsOwner()) throw new Exception("No authorization.");
            Contract.Destroy();
        }
    }
}

Invoke Put second time.

Request

{
  "jsonrpc": "2.0",
  "method": "invokefunction",
  "params": [
    "0xe04c57554ffafc05cce6bed65b7f013efd0f3660",
    "put",
    [
      {
        "type": "String",
        "value": "world"
      }
    ],
    [
      {
        "account": "NLtDqwnj9s7wQVyaiD5ohjV3e9fUVkZxDp",
        "scopes": "CalledByEntry"
      }
    ]
  ],
  "id": 3
}

{
    "jsonrpc": "2.0",
    "id": 3,
    "result": {
        "script": "DAV3b3JsZBHADANwdXQMFGA2D/0+AX9b1r7mzAX8+k9VV0zgQWJ9W1I=",
        "state": "HALT",
        "gasconsumed": "9013350",
        "exception": null,
        "stack": [
            {
                "type": "Any"
            }
        ],
        "tx": "APwDDidmiIkAAAAAAAZREgAAAAAAMRkAAAEKo4e1Ppa3mJpjFDGgVt0fQKBC9gEAKQwFd29ybGQRwAwDcHV0DBRgNg/9PgF/W9a+5swF/PpPVVdM4EFifVtSAUIMQHjWKfrIJf1HHjccEb3hEQuiGIZz4cdV6LyUBAoI9eMCWi3O2v1AnY+iUekPhGLQBb6FBeEUlRpl0XiJXF9toZcpDCEDzqPi+B8a+TUi0p7eTySh8L7erXKTOR0ziA9Uddl4eMkLQZVEDXg="
    }
}

GetApplicationLog

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "txid": "0xab9101da4367f47d897ee2766564ddc5819b1ca67c5cc797b3a76fb9d406373a",
        "executions": [
            {
                "trigger": "Application",
                "vmstate": "HALT",
                "gasconsumed": "9013350",
                "stack": [
                    {
                        "type": "Any"
                    }
                ],
                "notifications": [
                    {
                        "contract": "0xe04c57554ffafc05cce6bed65b7f013efd0f3660",
                        "eventname": "Word",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "ByteString",
                                    "value": "d29ybGQ="
                                }
                            ]
                        }
                    },
                    {
                        "contract": "0xe04c57554ffafc05cce6bed65b7f013efd0f3660",
                        "eventname": "InvokePutCount",
                        "state": {
                            "type": "Array",
                            "value": [
                                {
                                    "type": "ByteString",
                                    "value": "Ag=="
                                }
                            ]
                        }
                    }
                ]
            }
        ]
    }
}

It works well on mine.

superboyiii · 2020-11-16T08:45:05Z

@shargon Shall we make BigInteger can be added as well?

shargon · 2020-11-16T10:47:49Z

@superboyiii Biginteger use object.ToString(), so if we do that, it won't be accurate.

superboyiii · 2020-11-17T02:23:21Z

@superboyiii Biginteger use object.ToString(), so if we do that, it won't be accurate.

That's fine. It's good for me now.

cloud8little · 2020-11-17T06:23:44Z

@superboyiii Biginteger use object.ToString(), so if we do that, it won't be accurate.

It can be called like this instead of ToString():

        public static string test2()
        {
            BigInteger a = 200000000000000000;
            string b = "test: " + Binary.Itoa(a, 10);
            return b;
        }

shargon · 2020-11-19T11:15:16Z

Merge?

shargon · 2020-11-20T09:28:01Z

I will merge it, if there are any change we can do it in other Pull Request.

* Atoi/Itoa * Fix UT * Increase version * Fix UT * Add enter * Add more UT * Real fix * Update Contract_String.cs * fix lines

Atoi/Itoa

266a022

shargon requested a review from erikzhang November 8, 2020 09:32

Tommo-L previously approved these changes Nov 9, 2020

View reviewed changes

superboyiii previously approved these changes Nov 12, 2020

View reviewed changes

Merge branch 'master' into sync-neo

a4629f8

shargon dismissed stale reviews from superboyiii and Tommo-L via a4629f8 November 12, 2020 08:26

shargon added 4 commits November 12, 2020 09:39

Fix UT

c166534

Increase version

80da262

Fix UT

1514d0e

Add enter

27a8ce4

Tommo-L previously approved these changes Nov 12, 2020

View reviewed changes

superboyiii previously approved these changes Nov 13, 2020

View reviewed changes

Merge branch 'master' into sync-neo

6cdde5c

shargon dismissed stale reviews from superboyiii and Tommo-L via 6cdde5c November 13, 2020 11:21

shargon added 4 commits November 13, 2020 12:39

Add more UT

8a0d29c

Real fix

ba3477d

Update Contract_String.cs

5747695

fix lines

10ddae3

superboyiii approved these changes Nov 17, 2020

View reviewed changes

Merge branch 'master' into sync-neo

bf444f8

Tommo-L approved these changes Nov 20, 2020

View reviewed changes

Merge branch 'master' into sync-neo

432f765

shargon merged commit ac7e39c into neo-project:master Nov 20, 2020

shargon deleted the sync-neo branch November 20, 2020 09:29

Jim8y pushed a commit that referenced this pull request Aug 3, 2025

Add Atoi/Itoa (#389)

ac43ced

* Atoi/Itoa * Fix UT * Increase version * Fix UT * Add enter * Add more UT * Real fix * Update Contract_String.cs * fix lines

Jim8y pushed a commit that referenced this pull request Aug 18, 2025

Add Atoi/Itoa (#389)

47aae70

* Atoi/Itoa * Fix UT * Increase version * Fix UT * Add enter * Add more UT * Real fix * Update Contract_String.cs * fix lines

Conversation

shargon commented Nov 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tommo-L commented Nov 9, 2020

Uh oh!

superboyiii commented Nov 12, 2020

Uh oh!

superboyiii commented Nov 12, 2020

Uh oh!

Tommo-L commented Nov 12, 2020

Uh oh!

shargon commented Nov 12, 2020

Uh oh!

superboyiii commented Nov 13, 2020

Uh oh!

vncoelho commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shargon commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superboyiii commented Nov 16, 2020

Uh oh!

superboyiii commented Nov 16, 2020

Uh oh!

superboyiii commented Nov 16, 2020

Uh oh!

shargon commented Nov 16, 2020

Uh oh!

superboyiii commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloud8little commented Nov 17, 2020

Uh oh!

shargon commented Nov 19, 2020

Uh oh!

shargon commented Nov 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shargon commented Nov 8, 2020 •

edited

Loading

vncoelho commented Nov 13, 2020 •

edited

Loading

shargon commented Nov 14, 2020 •

edited

Loading

superboyiii commented Nov 17, 2020 •

edited

Loading