Merged
Conversation
erikzhang
reviewed
Nov 3, 2020
roman-khimov
reviewed
Nov 3, 2020
| return BinarySerializer.Deserialize(data, Limits.MaxStackSize, Limits.MaxItemSize, ReferenceCounter); | ||
| } | ||
|
|
||
| protected internal string Itoa(BigInteger value) |
Contributor
There was a problem hiding this comment.
I think base parameter would be nice to have here (and for Atoi).
Member
Author
There was a problem hiding this comment.
Please take a look, octal and binary was not added, do you think that it's needed?
Contributor
There was a problem hiding this comment.
To be fair I'd expect some regular 2-36 range to be supported here (like it's not a problem for big.Int in Go), but from a quick glance it looks like .NET's BigInteger doesn't make it easy even for 2-16 range (like in this SO q/a). So maybe we can try to go with only 10 and 16 supported for now, it's not that hard to extend it in the future if need be.
erikzhang
reviewed
Nov 5, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Erik Zhang <erik@neo.org>
erikzhang
reviewed
Nov 6, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Erik Zhang <erik@neo.org>
erikzhang
approved these changes
Nov 8, 2020
45 tasks
7 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Itoa atoi * add base * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut * Clean code * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut Co-authored-by: Erik Zhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Itoa atoi * add base * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut * Clean code * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/ApplicationEngine.Binary.cs Co-authored-by: Erik Zhang <erik@neo.org> * Fix ut Co-authored-by: Erik Zhang <erik@neo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for neo-project/neo-devpack-dotnet#385