Skip to content

_deploy compilation#364

Merged
shargon merged 15 commits intoneo-project:masterfrom
shargon:add-ondeploy
Sep 29, 2020
Merged

_deploy compilation#364
shargon merged 15 commits intoneo-project:masterfrom
shargon:add-ondeploy

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Sep 20, 2020

Close #363
Require neo-project/neo#1933

@shargon shargon marked this pull request as ready for review September 21, 2020 18:40
@shargon shargon requested a review from erikzhang September 21, 2020 18:40
@Tommo-L
Copy link
Copy Markdown
Contributor

Tommo-L commented Sep 24, 2020

Don't forget to update the example.

public static bool MyMethod()
{
Storage.Put("Hello", "World");
return true;
}
public static void Update(byte[] script, string manifest)

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Sep 26, 2020

Ready to review

@erikzhang
Copy link
Copy Markdown
Member

Why do we need these attributes? I think we just need to add two methods to the template.

public bool Verify()
{
}

[DisplayName("_deploy")]
public void Deploy(bool update)
{
}

Co-authored-by: Erik Zhang <erik@neo.org>
@shargon shargon merged commit 773194e into neo-project:master Sep 29, 2020
@shargon shargon deleted the add-ondeploy branch September 29, 2020 09:41
Jim8y pushed a commit that referenced this pull request Aug 3, 2025
* UT
* Deploy
* Use attribute
* Ensure method definition
* Fix json error
* Revert change
* Update demo
* Update Contract1.cs
* Use LF
* Add onVerify
* Remove attributes
* Update src/Neo.Compiler.MSIL/NeoModule.cs
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Erik Zhang <erik@neo.org>
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
* UT

* Deploy

* Use attribute

* Ensure method definition

* Fix json error

* Revert change

* Update demo

* Update Contract1.cs

* Use LF

* Add onVerify

* Remove attributes

* Update src/Neo.Compiler.MSIL/NeoModule.cs

Co-authored-by: Erik Zhang <erik@neo.org>

Co-authored-by: Erik Zhang <erik@neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_deploy compilation

3 participants