Call _deploy during deploy and update#1933
Merged
shargon merged 17 commits intoneo-project:masterfrom Sep 21, 2020
Merged
Conversation
devhawk
reviewed
Sep 14, 2020
Member
erikzhang
reviewed
Sep 15, 2020
Contributor
|
I'd like to know more about what the NEON developer experience will be for authoring the _deploy method. Just write a method named _deploy? Attribute? Are we going to check to ensure the method has the correct signature? Otherwise, looks good. |
Member
|
neo/src/neo/SmartContract/ApplicationEngine.cs Lines 100 to 104 in 64c3a87
|
erikzhang
reviewed
Sep 17, 2020
erikzhang
approved these changes
Sep 20, 2020
45 tasks
12 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Call _initialize during deploy and update * Change to _deploy * Remove var * Remove args * Reuse CallContractInternal() * void _deploy(bool updated); * Change push * Unify it * Fix needCheckReturnValue * Add else * Refactor needcheck return type Co-authored-by: erikzhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Call _initialize during deploy and update * Change to _deploy * Remove var * Remove args * Reuse CallContractInternal() * void _deploy(bool updated); * Change push * Unify it * Fix needCheckReturnValue * Add else * Refactor needcheck return type Co-authored-by: erikzhang <erik@neo.org>
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1932