Merged
Conversation
shargon
reviewed
Mar 24, 2020
lightszero
suggested changes
Mar 24, 2020
Member
|
@ShawnYun I just clear optimizer, check it please and continue. |
Member
|
sorry addrconvtable has bug,only convert labels,I will fix it. |
Contributor
Author
|
@lightszero Thanks, It's better now. |
Tommo-L
reviewed
Mar 26, 2020
Tommo-L
previously approved these changes
Mar 26, 2020
added 3 commits
April 23, 2020 16:00
Closed
Tommo-L
reviewed
Apr 24, 2020
Tommo-L
reviewed
Apr 24, 2020
tests/Neo.Compiler.MSIL.UnitTests/TestClasses/Contract_StaticVarInit.cs
Outdated
Show resolved
Hide resolved
tests/Neo.Compiler.MSIL.UnitTests/TestClasses/Contract_StaticVarInit.cs
Outdated
Show resolved
Hide resolved
Tommo-L
previously approved these changes
Apr 24, 2020
Contributor
Tommo-L
left a comment
There was a problem hiding this comment.
It's ready for review, @lightszero @shargon could help review it.
lightszero
previously approved these changes
Apr 26, 2020
Contributor
Author
|
@lightszero Thanks, Have fixed it. |
Tommo-L
approved these changes
Apr 26, 2020
lightszero
approved these changes
Apr 26, 2020
shargon
reviewed
Apr 27, 2020
| return new byte[1] { (byte)value }; | ||
| } | ||
| //[TestMethod] | ||
| //public void Test_Optimize_Recalculate_Positive_PUSHA() |
Member
There was a problem hiding this comment.
https://github.com/neo-project/neo-devpack-dotnet/pull/252/files#r415749579
This should not have been merged if it didn't work with the unit test, the solution is not to comment the code that doesn't work.
Contributor
Author
There was a problem hiding this comment.
@shargon Sorry, I will restore them after I fix the Parser_DeleteDeadCode.
Jim8y
pushed a commit
that referenced
this pull request
Aug 3, 2025
* add abi offset * fix * clean optimizer * Clean code * Update NefOptimizeTool.cs * fix GetAddrConvertTable bug，return all offsets now * format * format * Clean code * add abi-offset-unitTest * Rename Contract_AbiOffset.cs to Contract_ABIOffset.cs * fix * Clean code * Optimize * Fix * fix NDEBUG * Fix NDEBUG * modify abi offset uintTest * add initializing static variables * format * format * modify UTs * fix and rename * modify ContractTest * format * fix * fix TestEngine and modify _initialize * fix * format * fix void return * Update Opcodes * resolve review issues * fix * fix * fix Co-authored-by: lights <lightsever@hotmail.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org>
Jim8y
pushed a commit
that referenced
this pull request
Aug 18, 2025
* add abi offset * fix * clean optimizer * Clean code * Update NefOptimizeTool.cs * fix GetAddrConvertTable bug，return all offsets now * format * format * Clean code * add abi-offset-unitTest * Rename Contract_AbiOffset.cs to Contract_ABIOffset.cs * fix * Clean code * Optimize * Fix * fix NDEBUG * Fix NDEBUG * modify abi offset uintTest * add initializing static variables * format * format * modify UTs * fix and rename * modify ContractTest * format * fix * fix TestEngine and modify _initialize * fix * format * fix void return * Update Opcodes * resolve review issues * fix * fix * fix Co-authored-by: lights <lightsever@hotmail.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Erik Zhang <erik@neo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #207
@lightszero @shargon @Tommo-L Could you help review the code?