Skip to content

Ensure combined rules#253

Merged
lightszero merged 4 commits intomasterfrom
ensure-combined-rules
Apr 26, 2020
Merged

Ensure combined rules#253
lightszero merged 4 commits intomasterfrom
ensure-combined-rules

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Apr 24, 2020 •
edited
Loading

  • Fixed a bug in optimizer with short jumps
  • Ensure combined rules

@shargon shargon requested a review from lightszero April 24, 2020 17:30
@shargon
Copy link
Copy Markdown
Member Author

shargon commented Apr 24, 2020

Please @lightszero take a look to this script 2204114022fe it fails during optimization and make the UT fail

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Apr 24, 2020 •
edited
Loading

@lightszero done, we had a wrong address calculation when it's short jump and negative

@lightszero
Copy link
Copy Markdown
Member

lightszero commented Apr 26, 2020

got it.right,it is my bug.

@lightszero lightszero merged commit d6e5297 into master Apr 26, 2020
@lightszero lightszero deleted the ensure-combined-rules branch April 26, 2020 01:30
Jim8y pushed a commit that referenced this pull request Aug 3, 2025
@shargon
Ensure combined rules (#253)
b73bcfb 
* Ensure combined rules
* Change UT
* Fix negative JMP
* Clean code
Jim8y pushed a commit that referenced this pull request Aug 18, 2025
@shargon
Ensure combined rules (#253)
374250c 
* Ensure combined rules

* Change UT

* Fix negative JMP

* Clean code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lightszero lightszero lightszero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shargon @lightszero