Neo.SmartContract.Framework: add native Notary contract API#1300
Merged
Neo.SmartContract.Framework: add native Notary contract API#1300
Conversation
Ref. neo-project/neo#3178. Ported from #556 with all necessary updates. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
12 tasks
| public static extern bool Withdraw(UInt160 from, UInt160 to); | ||
| public static extern BigInteger BalanceOf(UInt160 acc); | ||
| public static extern uint ExpirationOf(UInt160 acc); | ||
| public static extern bool Verify(byte[] sig); |
Member
There was a problem hiding this comment.
Are you sure this method should be called verify one could act as the notary contract and use this in tx signature.
Member
Author
There was a problem hiding this comment.
The name is proper, it's standardize by https://github.com/neo-project/proposals/blob/master/nep-30.mediawiki. This method is designed specifically for transaction's witness verification.
shargon
previously approved these changes
Mar 5, 2025
Member
shargon
left a comment
There was a problem hiding this comment.
Wait for merge it, after it I will also update the testing engine
Wi1l-B0t
reviewed
Mar 5, 2025
| public static extern bool LockDepositUntil(UInt160 addr, uint till); | ||
| public static extern bool Withdraw(UInt160 from, UInt160 to); | ||
| public static extern BigInteger BalanceOf(UInt160 acc); | ||
| public static extern uint ExpirationOf(UInt160 acc); |
Contributor
There was a problem hiding this comment.
What is acc?
account?
It's better to use a complete word.
Jim8y
previously approved these changes
Mar 21, 2025
Wi1l-B0t
reviewed
Mar 21, 2025
Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Jim8y
approved these changes
Mar 21, 2025
cschuchardt88
approved these changes
Mar 21, 2025
Wi1l-B0t
approved these changes
Mar 22, 2025
shargon
approved these changes
Mar 22, 2025
Jim8y
pushed a commit
that referenced
this pull request
Aug 3, 2025
* Neo.SmartContract.Framework: add native Notary contract API Ref. neo-project/neo#3178. Ported from #556 with all necessary updates. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Update src/Neo.SmartContract.Framework/Native/Notary.cs Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Jimmy <jimmy@r3e.network> Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com>
Jim8y
added a commit
that referenced
this pull request
Aug 18, 2025
* Neo.SmartContract.Framework: add native Notary contract API Ref. neo-project/neo#3178. Ported from #556 with all necessary updates. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Update src/Neo.SmartContract.Framework/Native/Notary.cs Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Jimmy <jimmy@r3e.network> Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: Shargon <shargon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. neo-project/neo#3178.
Ported from #556 with all necessary updates, all credits go to @shargon.