Implement native Notary contract by AnnaShaleva · Pull Request #3178 · neo-project/neo

AnnaShaleva · 2024-03-19T17:40:21Z

Description

Implement native Notary contract.

Close #2897.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Native Gas contract unit tests;
Native Notary contract unit tests.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules:
- Neo.SmartContract.Framework: add native Notary contract API neo-devpack-dotnet#1300

Close #2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

…ribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Close #2897. Depends on #3175. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

vncoelho · 2024-03-19T18:05:28Z

Is this PR to be merged now or after next release?
I was planning to review current release and then merge these next feature.

roman-khimov · 2024-03-19T18:24:29Z

Is this PR to be merged now or after next release?

https://github.com/neo-project/neo/milestone/2

src/Neo/SmartContract/Native/Notary.cs

src/Neo/SmartContract/Native/GasToken.cs

src/Neo/SmartContract/Native/Notary.cs

dusmart · 2024-03-21T10:10:17Z

This contract has a Verify method which is very dangerous.

neo/src/Neo/SmartContract/Native/Notary.cs

Line 95 in 77ffe09

private bool Verify(ApplicationEngine engine, byte[] sig)

In this method, we verify that tx.Signers[1] has enough balance stored in the contract. Plus, we verify that a signature from any notary is provided.

Here is an attack vector. A malicious notary can sign as many transactions as it wants and then publish at most 500 txs on chain while tx.Signers[1] has a little balance only sufficient for one tx.

If it's not a malicious notary, someone could still get a chance to make the notary sign something multiple times and cache them then publish them at once.

By the way, do you know how many core modules will be affected by this notary feature? Is this the last PR?

src/Neo/SmartContract/Native/Notary.cs

vncoelho

I am not seeing the part of the code we discussed on Discord, @AnnaShaleva, you mentioned about a delegated powered notary signing.
"The contract itself don't send the transactions. It's a designated Notary node who is powered to send transactions on behalf of notary service users. "

I want to check that because it should be, at least, similar to the oracles design.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

No functional changes, just a refactoring. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva · 2024-03-21T18:29:31Z

By the way, do you know how many core modules will be affected by this notary feature? Is this the last PR?

To be able to process existing NeoFS chains that use Notary - yes, it's the last PR. But ideally in future we'd like to implement P2PNotaryRequest payload with pool (ref. nspcc-dev/neo-go#1546) and Notary service plugin (ref. nspcc-dev/neo-go#1547). We'll add related issues to neo-project later.

"The contract itself don't send the transactions. It's a designated Notary node who is powered to send transactions on behalf of notary service users. "
I want to check that because it should be, at least, similar to the oracles design.

It's a part of Notary service plugin. See the example implementation in https://github.com/nspcc-dev/neo-go/blob/master/pkg/services/notary/notary.go.

vang1ong7ang

as @dusmart said , verify method should be used with extreme caution. and is there a fork introduced?

roman-khimov · 2024-03-26T05:39:41Z

verify method should be used with extreme caution

That's a valid concern, but there are multiple ways to handle it, we'll get to it after #3175 merge.

Notary node account is always a standard single signature script. This commit fixes state difference between Go and C# nodes at block 9762 of NeoFS Testnet: ``` go run scripts/compare-dumps/compare-dumps.go ./godump-echidna-neofs-testnet/ ../../neo-project/neo/neo-cli-notary-testnet/Storage_2bdb2b5f/ Processing directory BlockStorage_0 Processing directory BlockStorage_100000 file BlockStorage_100000/dump-block-10000.json: block 9762, changes length mismatch: 13 vs 20 compare-dumps dumpDirA dumpDirB exit status 1 ``` The reason is in improper construction of Notary node address which leads to the fact that notary GAS reward goes to wrong addresses. Here's a part of OnPersist application log for this block generated by C# node that contains wrong GAS receiver addresses: ``` { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "Z0B9UyyyUsDlW4OgICWJ+nwLyZc=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "5Sk5i/oPh7IBb7VvlHfiUjX2LHU=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "HcOwwNv9mwY1i3SF4d5qX8jDdJs=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "8a2TEhIZFJ/lZDklkMs+d6i7OWI=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "Oke4DvOe+XZ+3mQnZ5nE1Ilm3jY=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "7frkdtIbPRN2ijaHnw+tfUxMzA8=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "YjI6lI1pOy/OxH1PjcG/yIXwD/4=" }, { "type": "Integer", "value": "11428571" } ] } } ], "stack": [ ], "trigger": "OnPersist", "vmstate": "HALT" } ``` Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

src/Neo/SmartContract/Native/Notary.cs

vncoelho · 2025-04-22T11:58:49Z

src/Neo/SmartContract/Native/Notary.cs

+            if (deposit is null)
+            {
+                var feePerKey = Policy.GetAttributeFeeV1(engine.SnapshotCache, (byte)TransactionAttributeType.NotaryAssisted);
+                if ((long)amount < 2 * feePerKey) throw new ArgumentOutOfRangeException(string.Format("first deposit can not be less than {0}, got {1}", 2 * feePerKey, amount));


I think that here we missed some standard fee instead of just the dynamic.

It's just a basic check that ensures that deposited value will be enough to pay for a fallback transaction.

src/Neo/SmartContract/Native/Notary.cs

vncoelho · 2025-04-22T12:16:57Z

src/Neo/SmartContract/Native/Notary.cs

+        /// <returns>result</returns>
+        private static long CalculateNotaryReward(IReadOnlyStore snapshot, long nFees, int notariesCount)
+        {
+            return nFees * Policy.GetAttributeFeeV1(snapshot, (byte)TransactionAttributeType.NotaryAssisted) / notariesCount;


Are we sure that this matches:

if (notaryAssisted is not null) { totalNetworkFee -= (notaryAssisted.NKeys + 1) * Policy.GetAttributeFeeV1(engine.SnapshotCache, (byte)notaryAssisted.Type); }

There we multiple. Here we divide then mint, are the rounding correct?
Maybe it would be safer to do the same calculation and then divide the sum correctly and precisely.

ping @shargon

The rounding is correct. We agree that there might be a situation when total notary reward is not divisible by notariesCount, then the reward per node will be rounded to lower integer value. The reminder will not be transferred to anyone, and we just live with it. So to us, it's not a problem since reminder is negligible.

If it's a problem, then we can always set NotaryAssisted attribute fee to be a multuple of notariesCount.

If it's a problem, then we can always set NotaryAssisted attribute fee to be a multuple of notariesCount.

It will be nice, every protection is good

It will be nice, every protection is good

It will be done by Committee via invocation of setAttributeFee. So I don't think we need to update the code.

It will be nice, every protection is good

It will be done by Committee via invocation of setAttributeFee. So I don't think we need to update the code.

but they can do the opposite

We still consider that this reminder is negligible and it doesn't worth to introduce dependency from RoleManagement into Policy contract to protect from possible committee misbehavior.

Committee can do a lot of wrong things, protecting from bad committee is impossible in general. Realistically this is never a problem even if there are some datoshis burned.

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Implement NotaryAssisted transaction attribute Close neo-project#2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: add NotaryAssisted attributes handler to Gas OnPersist Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: adjust comment to NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: temporary use hard-coded Notary contract hash Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: replace hard-coded Notary hash value with calculated one No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: implement native Notary contract Close neo-project#2897. Depends on neo-project#3175. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: fix typo in the exception message Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: use more syntactic sugar No functional changes, just a refactoring. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: add unit tests for OnNEP17Payment and ExpirationOf methods Also, mark improper code of Withdraw method with TODO, it should be reworked. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Fix transfer * Update tests/Neo.UnitTests/SmartContract/Native/UT_Notary.cs * Update UT_Notary.cs * fix * Fix notary * Fix notary * Notary: add unit tests for LockDepositUntil and BalanceOf methods Also, format code. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: test GAS distribution with FeePerKey update Test the situation described in https://github.com/neo-project/neo/pull/3175/files/00b54ff6d20cc84b435beaa790fe72a9d8f78bec#r1530493475. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: add test for Withdraw Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: remove unused code No functional changes, I just finally made my code analizer work properly. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Attributtes: fix NotaryAssisted attribute documentation format Co-authored-by: Shargon <shargon@gmail.com> * Native: update to the fresh master Fetch changes from the fresh master and fix build errors. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: sync up with master changes No functional changes, just adopt latest changes in syntax from master to make the code buildable and make unit tests pass. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: make the contract active starting from Echidna. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: add NEP-27 to the list of supported standards Port nspcc-dev/neo-go#3792. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: adjust deposit expiration rule Follow nspcc-dev/neo-go#3211. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * clean usings * Update tests/Neo.UnitTests/Extensions/Nep17NativeContractExtensions.cs Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> * Notary: improve long line format No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: prettify exception thrown on unexpected OnNEP17Payment data Throw FormatException instead of InvalidCastException on invalid data passed to OnNEP17Payment. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: don't FAULT execution in case of non-tx verification container Return `false` in case if execution container for `verify` is not a transaction. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: unify deposit lock validity check No functional changes, just a refactoring. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: extend `verify` with signature argument validation Ref. https://github.com/neo-project/neo/pull/3178/files/56acd97e4b2e93601b7e3d4b15b5ccafc9455fcd#r2010316964. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: add a note about Deposit serialization No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * UnitTests: remove NotaryAssisted fees unit test This test requires Notary nodes to be properly designated via native RoleManagement contract, it's hard to mock this behaviour during test, I wasn't able to properly do it. This test may be restored once we have better testing system. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: replace exceptions with false return for `withdraw` Ref. neo-project#3178 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: refactor variable definition No functional changes, ref. neo-project#3178 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: migrate to Policy.GetAttributeFeeV1 usage No functional changes, just adopt the neo-project#3859. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Review Notary (neo-project#3870) * Update Notary.cs * Update Notary.cs * Update Notary.cs * fix * clean * Clean * Update src/Neo/SmartContract/Native/Notary.cs * Update tests/Neo.UnitTests/TestUtils.Transaction.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update tests/Neo.UnitTests/TestUtils.Transaction.cs Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * Update tests/Neo.UnitTests/TestUtils.Transaction.cs * Update tests/Neo.UnitTests/TestUtils.Transaction.cs * Notary: adapt Policy-based MaxValidUntilBlockIncrement Fetch recent update from neo-project#3861. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: rename manifest parameters to follow the native style Unify parameters naming to follow the style of other native contracts. No functional changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: adjust required callflags for some methods Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Notary: fix Notary node scripthash construction Notary node account is always a standard single signature script. This commit fixes state difference between Go and C# nodes at block 9762 of NeoFS Testnet: ``` go run scripts/compare-dumps/compare-dumps.go ./godump-echidna-neofs-testnet/ ../../neo-project/neo/neo-cli-notary-testnet/Storage_2bdb2b5f/ Processing directory BlockStorage_0 Processing directory BlockStorage_100000 file BlockStorage_100000/dump-block-10000.json: block 9762, changes length mismatch: 13 vs 20 compare-dumps dumpDirA dumpDirB exit status 1 ``` The reason is in improper construction of Notary node address which leads to the fact that notary GAS reward goes to wrong addresses. Here's a part of OnPersist application log for this block generated by C# node that contains wrong GAS receiver addresses: ``` { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "Z0B9UyyyUsDlW4OgICWJ+nwLyZc=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "5Sk5i/oPh7IBb7VvlHfiUjX2LHU=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "HcOwwNv9mwY1i3SF4d5qX8jDdJs=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "8a2TEhIZFJ/lZDklkMs+d6i7OWI=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "Oke4DvOe+XZ+3mQnZ5nE1Ilm3jY=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "7frkdtIbPRN2ijaHnw+tfUxMzA8=" }, { "type": "Integer", "value": "11428571" } ] } }, { "contract": "0xd2a4cff31913016155e38e474a2c06d08be276cf", "eventname": "Transfer", "state": { "type": "Array", "value": [ { "type": "Any" }, { "type": "ByteString", "value": "YjI6lI1pOy/OxH1PjcG/yIXwD/4=" }, { "type": "Integer", "value": "11428571" } ] } } ], "stack": [ ], "trigger": "OnPersist", "vmstate": "HALT" } ``` Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>

AnnaShaleva and others added 8 commits March 6, 2024 12:00

Payloads: add doc to CalculateNetworkFee method of NotaryAssisted att…

acec1b0

…ribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Native: add NotaryAssisted attributes handler to Gas OnPersist

1508d4f

Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Payloads: adjust comment to NotaryAssisted attribute

8b547c9

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Merge branch 'master' into notary-assisted

00b54ff

Payloads: replace hard-coded Notary hash value with calculated one

24135ff

No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Native: implement native Notary contract

77ffe09

Close #2897. Depends on #3175. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva requested review from Jim8y, roman-khimov, shargon, superboyiii and vncoelho March 19, 2024 17:40

AnnaShaleva added the Waiting for Review label Mar 19, 2024

dusmart reviewed Mar 20, 2024

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Outdated Show resolved Hide resolved

cschuchardt88 suggested changes Mar 21, 2024

View reviewed changes

Hecate2 reviewed Mar 21, 2024

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Outdated Show resolved Hide resolved

cschuchardt88 reviewed Mar 21, 2024

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Show resolved Hide resolved

cschuchardt88 suggested changes Mar 21, 2024

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Outdated Show resolved Hide resolved

vncoelho reviewed Mar 21, 2024

View reviewed changes

AnnaShaleva mentioned this pull request Mar 21, 2024

Implement NotaryAssisted transaction attribute #3175

Merged

12 tasks

AnnaShaleva added 2 commits March 21, 2024 21:01

Native: fix typo in the exception message

cb4bdda

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Native: use more syntactic sugar

8f9f5f7

No functional changes, just a refactoring. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

vang1ong7ang suggested changes Mar 26, 2024

View reviewed changes

Merge branch 'master' into notary-contract

5ee1855

shargon previously approved these changes Apr 22, 2025

View reviewed changes

Merge branch 'master' into notary-contract

8e651dc

AnnaShaleva dismissed shargon’s stale review via 3318093 April 22, 2025 11:03

AnnaShaleva force-pushed the notary-contract branch from 3318093 to d6b043d Compare April 22, 2025 11:16

vncoelho reviewed Apr 22, 2025

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Show resolved Hide resolved

vncoelho reviewed Apr 22, 2025

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Show resolved Hide resolved

vncoelho reviewed Apr 22, 2025

View reviewed changes

vncoelho requested a review from vang1ong7ang April 22, 2025 12:06

vncoelho reviewed Apr 22, 2025

View reviewed changes

src/Neo/SmartContract/Native/Notary.cs Show resolved Hide resolved

vncoelho reviewed Apr 22, 2025

View reviewed changes

AnnaShaleva mentioned this pull request Apr 23, 2025

Native: revert Update/Deploy callflag change for pre-Aspidochelone #3909

Merged

11 tasks

NGDAdmin and others added 2 commits April 24, 2025 15:18

Merge branch 'master' into notary-contract

79968ba

Merge branch 'master' into notary-contract

206e9ad

Jim8y approved these changes Apr 27, 2025

View reviewed changes

NGDAdmin added 2 commits April 27, 2025 11:26

Merge branch 'master' into notary-contract

40536ba

Merge branch 'master' into notary-contract

f49134b

shargon approved these changes Apr 28, 2025

View reviewed changes

Wi1l-B0t approved these changes Apr 28, 2025

View reviewed changes

NGDAdmin merged commit a8b1f5a into master Apr 29, 2025
7 checks passed

NGDAdmin deleted the notary-contract branch April 29, 2025 02:26

mialbu mentioned this pull request Apr 29, 2025

Support new native Notary contract neow3j/neow3j#1114

Open

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port contract logic changes from reference

d149f20

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port contract logic changes from reference

b0f6620

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port contract logic changes from reference

da034ad

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port contract logic changes from reference

72677b6

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port Notary logic changes from reference

ce743ed

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port Notary logic changes from reference

759667f

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 30, 2025

native: port Notary logic changes from reference

05e3947

Ref. neo-project/neo#3178. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Conversation

AnnaShaleva commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

vncoelho commented Mar 19, 2024

Uh oh!

roman-khimov commented Mar 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dusmart commented Mar 21, 2024

Uh oh!

Uh oh!

Uh oh!

vncoelho left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva commented Mar 21, 2024

Uh oh!

vang1ong7ang left a comment

Choose a reason for hiding this comment

Uh oh!

roman-khimov commented Mar 26, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AnnaShaleva Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

AnnaShaleva commented Mar 19, 2024 •

edited

Loading

vncoelho left a comment •

edited

Loading

AnnaShaleva Apr 28, 2025 •

edited

Loading