Skip to content

Codecov badge#917

Merged
vncoelho merged 2 commits intomasterfrom
codecov-badge
Jul 13, 2019
Merged

Codecov badge#917
vncoelho merged 2 commits intomasterfrom
codecov-badge

Conversation

@vncoelho
Copy link
Copy Markdown
Member

@vncoelho vncoelho commented Jul 12, 2019

Replication and fix of coverage badge proposed by @lock9 on neo-vm: neo-project/neo-vm#186

@vncoelho vncoelho requested a review from lock9 July 12, 2019 17:23
@vncoelho
Copy link
Copy Markdown
Member Author

vncoelho commented Jul 12, 2019

@shargon, there is something strange still.

The PR #912 increases it to 50.59 and it should be described here:
https://codecov.io/github/eryeer/neoUT/branch/master/graph/badge.svg

However, the current badge for master already says 50%:
https://codecov.io/github/neo-project/neo/branch/master/graph/badge.svg

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 12, 2019

Codecov Report

Merging #917 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files         178      178           
  Lines       12609    12609           
=======================================
  Hits         5695     5695           
  Misses       6914     6914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76665c6...94233a5. Read the comment docs.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 12, 2019 •
edited
Loading

Codecov Report

Merging #917 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files         178      178           
  Lines       12609    12609           
=======================================
  Hits         5695     5695           
  Misses       6914     6914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76665c6...36dc162. Read the comment docs.

@vncoelho vncoelho merged commit d662e4a into master Jul 13, 2019
@vncoelho vncoelho deleted the codecov-badge branch July 13, 2019 14:25
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
remove invoke and clarify endianness (neo-project#917)
1bbcbc8
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
@vncoelho @Tommo-L
Codecov badge (neo-project#917)
338d050 
* Codecov badge

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@lock9 lock9 Awaiting requested review from lock9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vncoelho @codecov-io @shargon