Unit test for Persistence module and part of IO module#912
Unit test for Persistence module and part of IO module#912eryeer wants to merge 55 commits intoneo-project:masterfrom eryeer:master
Conversation
remote-tracking branch 'upstream/master'
Fix/db path
|
@lock9 do you have mac, could you fix travis? |
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 45.16% 50.59% +5.43%
==========================================
Files 178 178
Lines 12609 12609
==========================================
+ Hits 5695 6380 +685
+ Misses 6914 6229 -685
Continue to review full report at Codecov.
|
rm additional file and update method name
|
+5% nice work!!! |
|
CI is finally passed, thank you for you all‘s help😄 |
|
Please, Take a look to my pr https://github.com/eryeer/neoUT/pull/5 |
Clean ut
vncoelho
left a comment
There was a problem hiding this comment.
Such a nice job! Congratulations to all involved person.
5% with a different set of tests, covering different parts.
|
Hi everyone. I need to close this PR because we need to remove |
|
Ok, @eryeer. This is a great job from all of you. |
* update fees related info * Update English * follow up
Hi,everybody, this is the first submission of the Unit Test by the NGD team. Please take a look and welcome your comments.
We have one suggestion about the code directory structure.
At present, all the test code is placed in the first-level directory. Since there will be more subsequent UT codes to be added, is it possible to establish a one-to-one test code directory structure according to the structure of the Neo code?
For example, if the Neo's Block.cs file is located in Network/P2P/Payloads/Block.cs, the UT_BLOCK.cs file will be placed in the Network/P2P/Payloads/UT_Block.cs location of the UT project.
If this is the case, we can assist with the overall code directory structure adjustment.