Skip to content

Add Neo.Iterator.Concat#615

Merged
erikzhang merged 2 commits intoneo-project:masterfrom
afragapane:concatiterator
Mar 4, 2019
Merged

Add Neo.Iterator.Concat#615
erikzhang merged 2 commits intoneo-project:masterfrom
afragapane:concatiterator

Conversation

@afragapane
Copy link
Copy Markdown
Contributor

@afragapane afragapane commented Mar 1, 2019

Description of the Change

Add new API for Neo.Contract: Neo.Iterator.Concat as per #361.

Test Plan

Added a unit test of the functionality of ConcatenatedIterator.

Benefits

This will help allow typescript smart contracts compiled by neo-one to be deployed on the main neo network.
@dicarlo2

Applicable Issues

Closes #361

@dicarlo2
Copy link
Copy Markdown

dicarlo2 commented Mar 1, 2019

@jsolman

@jsolman jsolman requested a review from erikzhang March 2, 2019 00:09
Copy link
Copy Markdown
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me. Going to wait for Erik to approve it though, since #361 was left with his open question.

@erikzhang erikzhang added this to the NEO 3.0 milestone Mar 4, 2019
@erikzhang erikzhang merged commit 8f6865f into neo-project:master Mar 4, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
* 2.9.0

* updates for 2.9.0

* Update v2.9.0.md (neo-project#610)

Adjustment for instruction of getting nep-5 applicationlog.

* Update invokescript.md (neo-project#613)

Add tx

* Update invokefunction.md (neo-project#612)

Add tx for response.

* Create getwalletheight (neo-project#611)

Add getwalletheight api.

* updates for 2.9.0

* minor updates

* Update setup.md (neo-project#617)

Add introduction of Plugins.

* Update v2.9.0.md (neo-project#615)

Add introduction for setting config.json

* final updates

* Update v2.9.0.md (neo-project#618)

Add notes for install plugins.

* plugin related
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants