Support backward compatibility with older consensus payloads for seed nodes#610
Closed
jsolman wants to merge 1 commit intoconsensus/improved_dbftfrom
Closed
Support backward compatibility with older consensus payloads for seed nodes#610jsolman wants to merge 1 commit intoconsensus/improved_dbftfrom
jsolman wants to merge 1 commit intoconsensus/improved_dbftfrom
Conversation
This was referenced Feb 26, 2019
Merged
Member
|
Modifying |
Member
|
Otherwise, after a while, our code will look like this: writer.Write(Version);
if (Version > 0)
{
writer.Write(PrevHash);
}
else
{
writer.Write(BlockIndex);
writer.Write(ValidatorIndex);
}
if (Version == 2)
{
writer.Write(0);
}
if (Version >= 2)
{
writer.WriteVarBytes(Data);
}
if (Version >= 3)
{
} |
Contributor
Author
In Neo 3.0 when starting from a new Genesis block we can get rid of handling of prior versions. |
Contributor
Author
|
I think in this case upping the version is necessary. |
Contributor
Author
|
Closing in favor of #609 |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* 2.9.0 * updates for 2.9.0 * Update v2.9.0.md (neo-project#610) Adjustment for instruction of getting nep-5 applicationlog. * Update invokescript.md (neo-project#613) Add tx * Update invokefunction.md (neo-project#612) Add tx for response. * Create getwalletheight (neo-project#611) Add getwalletheight api. * updates for 2.9.0 * minor updates * Update setup.md (neo-project#617) Add introduction of Plugins. * Update v2.9.0.md (neo-project#615) Add introduction for setting config.json * final updates * Update v2.9.0.md (neo-project#618) Add notes for install plugins. * plugin related
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for dBFT 2.0 need to be able to run on seed nodes before the CN nodes are upgraded. This fixes incompatibilities staying connected to other nodes in the network when running in a network where the CN nodes are running the original dBFT implementation.