Skip to content

[Fix] Avoid empty snupkg in release#3925

Merged
shargon merged 1 commit intov3.8from
fix-wf
May 6, 2025
Merged

[Fix] Avoid empty snupkg in release#3925
shargon merged 1 commit intov3.8from
fix-wf

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented May 6, 2025

Description

Close #3923

Fix empty snupkg files

Before:

image

After:

image

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon requested a review from superboyiii May 6, 2025 09:02
@shargon shargon changed the title Avoid empty snupkg in release [fix] Avoid empty snupkg in release May 6, 2025
@shargon shargon changed the title [fix] Avoid empty snupkg in release [Fix] Avoid empty snupkg in release May 6, 2025
Copy link
Copy Markdown
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shargon shargon changed the base branch from master to v3.8 May 6, 2025 09:38
@shargon shargon merged commit f108786 into v3.8 May 6, 2025
6 of 7 checks passed
@shargon shargon deleted the fix-wf branch May 6, 2025 14:24
shargon added a commit that referenced this pull request May 12, 2025
* [`Optimize`]: show native contract is active or not (#3922)

* optimize: show native contract net active yet

* Update src/Neo.CLI/CLI/MainService.Native.cs

* style: move BigInteger extensions from Utility to BigIntegerExtensions (#3916)

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Avoid empty snupkg in release (#3925)

* v3.8.1 (#3930)

* Revert workflow branch

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
* [`Optimize`]: show native contract is active or not (neo-project#3922)

* optimize: show native contract net active yet

* Update src/Neo.CLI/CLI/MainService.Native.cs

* style: move BigInteger extensions from Utility to BigIntegerExtensions (neo-project#3916)

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Avoid empty snupkg in release (neo-project#3925)

* v3.8.1 (neo-project#3930)

* Revert workflow branch

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow is stuck when updating nugets for release

3 participants