Skip to content

[Optimize]: show native contract is active or not#3922

Merged
NGDAdmin merged 4 commits intoneo-project:v3.8from
Wi1l-B0t:feat.show-net-active-yet
May 6, 2025
Merged

[Optimize]: show native contract is active or not#3922
NGDAdmin merged 4 commits intoneo-project:v3.8from
Wi1l-B0t:feat.show-net-active-yet

Conversation

@Wi1l-B0t
Copy link
Contributor

@Wi1l-B0t Wi1l-B0t commented May 5, 2025

Description

Optimzie show contract and list nativecontract

  1. list nativecontract shows the not actived contract, but show contract show that it not exists
    Before:
neo> list nativecontract
	ContractManagement  0xfffdc93764dbaddd97c48f252a53ea4643faa3fd
	StdLib              0xacce6fd80d44e1796aa0c2c625e9e4e0ce39efc0
	CryptoLib           0x726cb6e0cd8628a1350a611384688911ab75f51b
	LedgerContract      0xda65b600f7124ce6c79950c1772a36403104f2be
	NeoToken            0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5
	GasToken            0xd2a4cff31913016155e38e474a2c06d08be276cf
	PolicyContract      0xcc5e4edd9f5f8dba8bb65734541df7a1c081c67b
	RoleManagement      0x49cf4e5378ffcd4dec034fd98a174c5491e395e2
	OracleContract      0xfe924b7cfe89ddd271abaf7210a80a7e11178758
	Notary              0xc1e14f19c3e60d0b9244d06dd7ba9b113135ec3b

neo> show contract Notary
Error: Contract Notary doesn't exist.

After:

neo> list nativecontract
	ContractManagement  0xfffdc93764dbaddd97c48f252a53ea4643faa3fd
	StdLib              0xacce6fd80d44e1796aa0c2c625e9e4e0ce39efc0
	CryptoLib           0x726cb6e0cd8628a1350a611384688911ab75f51b
	LedgerContract      0xda65b600f7124ce6c79950c1772a36403104f2be
	NeoToken            0xef4073a0f2b305a38ec4050e4d3d28bc40ea63f5
	GasToken            0xd2a4cff31913016155e38e474a2c06d08be276cf
	PolicyContract      0xcc5e4edd9f5f8dba8bb65734541df7a1c081c67b
	RoleManagement      0x49cf4e5378ffcd4dec034fd98a174c5491e395e2
	OracleContract      0xfe924b7cfe89ddd271abaf7210a80a7e11178758
	Notary              0xc1e14f19c3e60d0b9244d06dd7ba9b113135ec3b (not active yet)

neo> show contract Notary
Error: Contract Notary not active yet.

Fixes # (issue)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AnnaShaleva AnnaShaleva mentioned this pull request May 6, 2025
@NGDAdmin
Copy link
Collaborator

NGDAdmin commented May 6, 2025

@Wi1l-B0t Could you push it to v3.8 branch? We will release v3.8.1 based on that branch. Then it will be merged into master.

@shargon shargon changed the base branch from master to v3.8 May 6, 2025 09:44
@shargon
Copy link
Member

shargon commented May 6, 2025

@NGDAdmin done

@NGDAdmin NGDAdmin merged commit 6bc7d19 into neo-project:v3.8 May 6, 2025
7 checks passed
@vncoelho
Copy link
Member

vncoelho commented May 6, 2025

Good!

@Wi1l-B0t Wi1l-B0t deleted the feat.show-net-active-yet branch May 7, 2025 14:16
@Wi1l-B0t
Copy link
Contributor Author

Wi1l-B0t commented May 7, 2025

@Wi1l-B0t Could you push it to v3.8 branch? We will release v3.8.1 based on that branch. Then it will be merged into master.

the release branch(s) shoule be independent and only bugfix can merge into it.
So bugfix need to be merge multi-times.

shargon added a commit that referenced this pull request May 12, 2025
* [`Optimize`]: show native contract is active or not (#3922)

* optimize: show native contract net active yet

* Update src/Neo.CLI/CLI/MainService.Native.cs

* style: move BigInteger extensions from Utility to BigIntegerExtensions (#3916)

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Avoid empty snupkg in release (#3925)

* v3.8.1 (#3930)

* Revert workflow branch

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
* [`Optimize`]: show native contract is active or not (neo-project#3922)

* optimize: show native contract net active yet

* Update src/Neo.CLI/CLI/MainService.Native.cs

* style: move BigInteger extensions from Utility to BigIntegerExtensions (neo-project#3916)

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Avoid empty snupkg in release (neo-project#3925)

* v3.8.1 (neo-project#3930)

* Revert workflow branch

---------

Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants