Add Support for Plugin Loading by Assembly by cschuchardt88 · Pull Request #3755 · neo-project/neo

cschuchardt88 · 2025-02-13T05:26:37Z

Description

The EnableDynamicLoading property indicates that an assembly is a dynamically loaded component. The component could be a COM library or a non-COM library that can be used from a native host or used as a plugin. Setting this property to true has the following effects:

A .runtimeconfig.json file is generated.
RollForward is set to LatestMinor.
NuGet references are copied locally.

Added property below to all the plugins.

<EnableDynamicLoading>true</EnableDynamicLoading>

Fixes # (issue)

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

shargon

Move to Directory.Build.props?

cschuchardt88 · 2025-02-13T08:32:43Z

Move to Directory.Build.props?

I will....

nan01ab · 2025-02-13T12:43:12Z

LGTM

shargon · 2025-02-13T14:31:00Z

Move to Directory.Build.props?

I will....

Before merge please

cschuchardt88 · 2025-02-13T16:51:23Z

Move to Directory.Build.props?

I will....

Before merge please

DONE!!! 😃

vncoelho

check conflict

@shargon

* Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

@shargon

* Implement NotaryAssisted transaction attribute Close #2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: add NotaryAssisted attributes handler to Gas OnPersist Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: adjust comment to NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: temporary use hard-coded Notary contract hash Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: replace hard-coded Notary hash value with calculated one No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NeoModules: integrate NotaryAssisted attribute Port the neo-project/neo-modules#884. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: fix XML comment formatting Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under D hardfork Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under E hardfork D hardfork was occupied by 3.7.5, thus use the next available one. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * tests: fix build errors No functional changes, just build fixes required by updated master branch. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NotaryAssisted: update copyright date Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * SmartContract: refactor obsolete code Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Persistance: fix UT Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Clean comments * Native: improve exception message for Policy's getFee/setFee Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * EC Recover (#3696) * EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * Improve MaxNestingDepth of WitnessCondition (#3761) * tests: add UT for nested WitnessCondition This just works as the code works. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify nesting checks, fix MaxNestingDepth 1. We have some duplication around "maxNestDepth <= 0" checks. 2. If we're to fix them by moving to DeserializeFrom() and thereby affecting all types of conditions we can discover a simple truth about conditions that was hidden previously: our real supported MaxNestingDepth is 3, not 2. 3. Test_WitnessCondition_Nesting works as before, check it there, we have And->And->Boolean and other nesting cases, 3-4 elements in the chain, not 2. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify JSON parsing as well Signed-off-by: Roman Khimov <roman@nspcc.ru> * tests: s/WitnessContition/WitnessCondition/ Fix typo. Signed-off-by: Roman Khimov <roman@nspcc.ru> * Format header * Format arrays in UT_WitnessCondition.cs --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Add Support for Plugin Loading by Assembly (#3755) * Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Optimize `StorageKey` creation (#3756) * Optimize key builder * Optimize with GetSpan * Use Span * Clean * Rename * Update src/Neo/SmartContract/KeyBuilder.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update KeyBuilder.cs * @cschuchardt88 feedback * Avoid ToArray in StorageKey constructor * Use sizeof * Optimize ECPoint * Optimize ECPoint * Add ISerializableSpan * Move to StorageKey * Use ReadOnlySpan --------- Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [`Fix`] Linux File Access (#3769) * Add some stuff to hope once and for all fix the linux workflows * update workflow * update nuget.yml * Change dig to detailed, log too big * Fix targets * revert main.yml * Update .github/workflows/main.yml * disable BuildInParallel --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Update src/Neo/SmartContract/Native/PolicyContract.cs * UnitTests: migrate NotaryAssisted test from MSTestV1 to MSTestV2 Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: nan01ab <yjcc201374@outlook.com>

@shargon

* Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

@shargon

* Implement NotaryAssisted transaction attribute Close neo-project#2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: add NotaryAssisted attributes handler to Gas OnPersist Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: adjust comment to NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: temporary use hard-coded Notary contract hash Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: replace hard-coded Notary hash value with calculated one No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NeoModules: integrate NotaryAssisted attribute Port the neo-project/neo-modules#884. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: fix XML comment formatting Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under D hardfork Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under E hardfork D hardfork was occupied by 3.7.5, thus use the next available one. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * tests: fix build errors No functional changes, just build fixes required by updated master branch. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NotaryAssisted: update copyright date Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * SmartContract: refactor obsolete code Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Persistance: fix UT Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Clean comments * Native: improve exception message for Policy's getFee/setFee Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * EC Recover (neo-project#3696) * EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * Improve MaxNestingDepth of WitnessCondition (neo-project#3761) * tests: add UT for nested WitnessCondition This just works as the code works. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify nesting checks, fix MaxNestingDepth 1. We have some duplication around "maxNestDepth <= 0" checks. 2. If we're to fix them by moving to DeserializeFrom() and thereby affecting all types of conditions we can discover a simple truth about conditions that was hidden previously: our real supported MaxNestingDepth is 3, not 2. 3. Test_WitnessCondition_Nesting works as before, check it there, we have And->And->Boolean and other nesting cases, 3-4 elements in the chain, not 2. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify JSON parsing as well Signed-off-by: Roman Khimov <roman@nspcc.ru> * tests: s/WitnessContition/WitnessCondition/ Fix typo. Signed-off-by: Roman Khimov <roman@nspcc.ru> * Format header * Format arrays in UT_WitnessCondition.cs --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Add Support for Plugin Loading by Assembly (neo-project#3755) * Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Optimize `StorageKey` creation (neo-project#3756) * Optimize key builder * Optimize with GetSpan * Use Span * Clean * Rename * Update src/Neo/SmartContract/KeyBuilder.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update KeyBuilder.cs * @cschuchardt88 feedback * Avoid ToArray in StorageKey constructor * Use sizeof * Optimize ECPoint * Optimize ECPoint * Add ISerializableSpan * Move to StorageKey * Use ReadOnlySpan --------- Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [`Fix`] Linux File Access (neo-project#3769) * Add some stuff to hope once and for all fix the linux workflows * update workflow * update nuget.yml * Change dig to detailed, log too big * Fix targets * revert main.yml * Update .github/workflows/main.yml * disable BuildInParallel --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Update src/Neo/SmartContract/Native/PolicyContract.cs * UnitTests: migrate NotaryAssisted test from MSTestV1 to MSTestV2 Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: nan01ab <yjcc201374@outlook.com>

Add Support for plugin loading

2119513

cschuchardt88 requested review from Jim8y, nan01ab, shargon and superboyiii February 13, 2025 05:26

cschuchardt88 self-assigned this Feb 13, 2025

cschuchardt88 added Waiting for Review Plugins labels Feb 13, 2025

shargon reviewed Feb 13, 2025

View reviewed changes

Merge branch 'master' into fix/plugins-loading-assembly

77a2f16

shargon previously approved these changes Feb 13, 2025

View reviewed changes

shargon self-requested a review February 13, 2025 11:28

nan01ab previously approved these changes Feb 13, 2025

View reviewed changes

cschuchardt88 added Ready to Merge and removed Waiting for Review labels Feb 13, 2025

cschuchardt88 added 2 commits February 13, 2025 11:47

Merge branch 'master' into fix/plugins-loading-assembly

41fbe94

Added @shargon request of changes

3b7b167

cschuchardt88 dismissed stale reviews from shargon and nan01ab via 3b7b167 February 13, 2025 16:51

cschuchardt88 added the Needs Reapproved Already "ready for merge" label Feb 13, 2025

cschuchardt88 requested a review from nan01ab February 13, 2025 16:52

Merge branch 'master' into fix/plugins-loading-assembly

8751c1e

shargon previously approved these changes Feb 13, 2025

View reviewed changes

nan01ab previously approved these changes Feb 14, 2025

View reviewed changes

cschuchardt88 removed the Needs Reapproved Already "ready for merge" label Feb 14, 2025

superboyiii approved these changes Feb 14, 2025

View reviewed changes

shargon and others added 4 commits February 14, 2025 00:01

Merge branch 'master' into fix/plugins-loading-assembly

47fbf45

Merge branch 'master' into fix/plugins-loading-assembly

860ce7d

Merge branch 'master' into fix/plugins-loading-assembly

38a4441

Merge branch 'master' into fix/plugins-loading-assembly

737069d

vncoelho reviewed Feb 16, 2025

View reviewed changes

Merge branch 'master' into fix/plugins-loading-assembly

c85ebd8

shargon dismissed stale reviews from nan01ab and themself via c85ebd8 February 16, 2025 15:16

shargon approved these changes Feb 16, 2025

View reviewed changes

cschuchardt88 and others added 2 commits February 17, 2025 01:07

Merge branch 'master' into fix/plugins-loading-assembly

24331ed

Merge branch 'master' into fix/plugins-loading-assembly

cf08128

nan01ab approved these changes Feb 17, 2025

View reviewed changes

shargon merged commit fe0f732 into neo-project:master Feb 17, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Plugin Loading by Assembly#3755

Add Support for Plugin Loading by Assembly#3755
shargon merged 12 commits intoneo-project:masterfrom
cschuchardt88:fix/plugins-loading-assembly

cschuchardt88 commented Feb 13, 2025 •

edited

Loading

Uh oh!

shargon left a comment

Uh oh!

cschuchardt88 commented Feb 13, 2025

Uh oh!

nan01ab commented Feb 13, 2025

Uh oh!

shargon commented Feb 13, 2025

Uh oh!

cschuchardt88 commented Feb 13, 2025

Uh oh!

vncoelho left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

cschuchardt88 commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Added property below to all the plugins.

Type of change

Checklist:

Uh oh!

shargon left a comment

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 commented Feb 13, 2025

Uh oh!

nan01ab commented Feb 13, 2025

Uh oh!

shargon commented Feb 13, 2025

Uh oh!

cschuchardt88 commented Feb 13, 2025

Uh oh!

vncoelho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cschuchardt88 commented Feb 13, 2025 •

edited

Loading