EC Recover by shargon · Pull Request #3696 · neo-project/neo

shargon · 2025-01-24T08:50:39Z

Description

Close #3628
Alternative to #3633

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Crypto tests

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

src/Neo/SmartContract/Native/CryptoLib.cs

shargon · 2025-01-24T09:18:11Z

@neo-project/core Please take special look into HashAlgorithm.None I think that is well implemented and it can't produce a state difference in other places

src/Neo/Cryptography/Crypto.cs

src/Neo/SmartContract/Native/CryptoLib.cs

tests/Neo.UnitTests/Cryptography/UT_Crypto.cs

Jim8y · 2025-02-14T12:15:22Z

@Jim8y thanks for fix it!

my pleasure

src/Neo/Cryptography/Crypto.cs

src/Neo/SmartContract/Native/CryptoLib.cs

* EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu>

@shargon

* Implement NotaryAssisted transaction attribute Close #2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: add NotaryAssisted attributes handler to Gas OnPersist Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: adjust comment to NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: temporary use hard-coded Notary contract hash Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: replace hard-coded Notary hash value with calculated one No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NeoModules: integrate NotaryAssisted attribute Port the neo-project/neo-modules#884. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: fix XML comment formatting Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under D hardfork Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under E hardfork D hardfork was occupied by 3.7.5, thus use the next available one. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * tests: fix build errors No functional changes, just build fixes required by updated master branch. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NotaryAssisted: update copyright date Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * SmartContract: refactor obsolete code Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Persistance: fix UT Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Clean comments * Native: improve exception message for Policy's getFee/setFee Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * EC Recover (#3696) * EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * Improve MaxNestingDepth of WitnessCondition (#3761) * tests: add UT for nested WitnessCondition This just works as the code works. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify nesting checks, fix MaxNestingDepth 1. We have some duplication around "maxNestDepth <= 0" checks. 2. If we're to fix them by moving to DeserializeFrom() and thereby affecting all types of conditions we can discover a simple truth about conditions that was hidden previously: our real supported MaxNestingDepth is 3, not 2. 3. Test_WitnessCondition_Nesting works as before, check it there, we have And->And->Boolean and other nesting cases, 3-4 elements in the chain, not 2. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify JSON parsing as well Signed-off-by: Roman Khimov <roman@nspcc.ru> * tests: s/WitnessContition/WitnessCondition/ Fix typo. Signed-off-by: Roman Khimov <roman@nspcc.ru> * Format header * Format arrays in UT_WitnessCondition.cs --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Add Support for Plugin Loading by Assembly (#3755) * Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Optimize `StorageKey` creation (#3756) * Optimize key builder * Optimize with GetSpan * Use Span * Clean * Rename * Update src/Neo/SmartContract/KeyBuilder.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update KeyBuilder.cs * @cschuchardt88 feedback * Avoid ToArray in StorageKey constructor * Use sizeof * Optimize ECPoint * Optimize ECPoint * Add ISerializableSpan * Move to StorageKey * Use ReadOnlySpan --------- Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [`Fix`] Linux File Access (#3769) * Add some stuff to hope once and for all fix the linux workflows * update workflow * update nuget.yml * Change dig to detailed, log too big * Fix targets * revert main.yml * Update .github/workflows/main.yml * disable BuildInParallel --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Update src/Neo/SmartContract/Native/PolicyContract.cs * UnitTests: migrate NotaryAssisted test from MSTestV1 to MSTestV2 Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: nan01ab <yjcc201374@outlook.com>

Port neo-project/neo#3696. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu>

@shargon

* Implement NotaryAssisted transaction attribute Close neo-project#2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Native: add NotaryAssisted attributes handler to Gas OnPersist Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: adjust comment to NotaryAssisted attribute Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: temporary use hard-coded Notary contract hash Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: replace hard-coded Notary hash value with calculated one No functional changes, just a refactoring for better code readability. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NeoModules: integrate NotaryAssisted attribute Port the neo-project/neo-modules#884. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Payloads: fix XML comment formatting Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under D hardfork Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * P2P: move NotaryAssisted transaction attribute under E hardfork D hardfork was occupied by 3.7.5, thus use the next available one. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * tests: fix build errors No functional changes, just build fixes required by updated master branch. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * NotaryAssisted: update copyright date Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * SmartContract: refactor obsolete code Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Persistance: fix UT Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Clean comments * Native: improve exception message for Policy's getFee/setFee Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * EC Recover (neo-project#3696) * EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <jinghui@wayne.edu> * Improve MaxNestingDepth of WitnessCondition (neo-project#3761) * tests: add UT for nested WitnessCondition This just works as the code works. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify nesting checks, fix MaxNestingDepth 1. We have some duplication around "maxNestDepth <= 0" checks. 2. If we're to fix them by moving to DeserializeFrom() and thereby affecting all types of conditions we can discover a simple truth about conditions that was hidden previously: our real supported MaxNestingDepth is 3, not 2. 3. Test_WitnessCondition_Nesting works as before, check it there, we have And->And->Boolean and other nesting cases, 3-4 elements in the chain, not 2. Signed-off-by: Roman Khimov <roman@nspcc.ru> * WitnessCondition: unify JSON parsing as well Signed-off-by: Roman Khimov <roman@nspcc.ru> * tests: s/WitnessContition/WitnessCondition/ Fix typo. Signed-off-by: Roman Khimov <roman@nspcc.ru> * Format header * Format arrays in UT_WitnessCondition.cs --------- Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Add Support for Plugin Loading by Assembly (neo-project#3755) * Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> * Optimize `StorageKey` creation (neo-project#3756) * Optimize key builder * Optimize with GetSpan * Use Span * Clean * Rename * Update src/Neo/SmartContract/KeyBuilder.cs Co-authored-by: nan01ab <yjcc201374@outlook.com> * Update KeyBuilder.cs * @cschuchardt88 feedback * Avoid ToArray in StorageKey constructor * Use sizeof * Optimize ECPoint * Optimize ECPoint * Add ISerializableSpan * Move to StorageKey * Use ReadOnlySpan --------- Co-authored-by: nan01ab <yjcc201374@outlook.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> * [`Fix`] Linux File Access (neo-project#3769) * Add some stuff to hope once and for all fix the linux workflows * update workflow * update nuget.yml * Change dig to detailed, log too big * Fix targets * revert main.yml * Update .github/workflows/main.yml * disable BuildInParallel --------- Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> * Update src/Neo/SmartContract/Native/PolicyContract.cs * UnitTests: migrate NotaryAssisted test from MSTestV1 to MSTestV2 Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Signed-off-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Roman Khimov <roman@nspcc.ru> Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com> Co-authored-by: nan01ab <yjcc201374@outlook.com>

EC Recover

6a6e43f

shargon mentioned this pull request Jan 24, 2025

EcRecover #3633

Closed

15 tasks

shargon added 3 commits January 24, 2025 09:55

Clean code

2df4dff

Fix ut

d6be966

Fix ut

48aaea1

mialbu reviewed Jan 24, 2025

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

shargon added 2 commits January 24, 2025 10:08

Unify hashing

7c9eda3

Allow HashAlgorithm.None

0b4f063

shargon marked this pull request as ready for review January 24, 2025 09:12

Clean comment

1cfbfa5

shargon added Waiting for Review Hardfork labels Jan 24, 2025

shargon commented Jan 24, 2025

View reviewed changes

src/Neo/Cryptography/Crypto.cs Outdated Show resolved Hide resolved

shargon added 2 commits January 24, 2025 01:19

Update src/Neo/Cryptography/Crypto.cs

3d9cfe7

Merge branch 'master' into ec-recover-v2

571edf5

shargon requested a review from Jim8y January 26, 2025 10:11

Jim8y reviewed Jan 27, 2025

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

shargon added 2 commits February 4, 2025 01:33

Merge branch 'master' into ec-recover-v2

ce377a6

Fix merge

54b7e41

shargon commented Feb 4, 2025

View reviewed changes

tests/Neo.UnitTests/Cryptography/UT_Crypto.cs Outdated Show resolved Hide resolved

shargon added 3 commits February 4, 2025 10:50

Add None check

2440366

Fix GetHash

739786e

Resolve conflicts and remove None

7c31eae

shargon added the Help Wanted We suggest a careful read at https://docs.neo.org/. However, fell free to further discuss the topic. label Feb 11, 2025

shargon requested a review from Jim8y February 11, 2025 11:50

Jim8y self-assigned this Feb 13, 2025

Jimmy added 3 commits February 14, 2025 18:54

Merge branch 'master' into ec-recover-v2

04f8651

Merge branch 'master' into ec-recover-v2

816b693

fix unit testing issues

9a3d9c5

Jim8y previously approved these changes Feb 14, 2025

View reviewed changes

shargon commented Feb 14, 2025

View reviewed changes

src/Neo/Cryptography/Crypto.cs Outdated Show resolved Hide resolved

Clean code

3bccdb4

shargon dismissed Jim8y’s stale review via 3bccdb4 February 14, 2025 12:32

shargon requested a review from Jim8y February 14, 2025 12:33

shargon added the Ready to Merge label Feb 14, 2025

Jim8y previously approved these changes Feb 15, 2025

View reviewed changes

cschuchardt88 previously approved these changes Feb 15, 2025

View reviewed changes

cschuchardt88 removed the Waiting for Review label Feb 15, 2025

nan01ab previously approved these changes Feb 15, 2025

View reviewed changes

Merge branch 'master' into ec-recover-v2

e6f1312

shargon commented Feb 15, 2025

View reviewed changes

src/Neo/SmartContract/Native/CryptoLib.cs Outdated Show resolved Hide resolved

Update src/Neo/SmartContract/Native/CryptoLib.cs

aedbc82

shargon dismissed stale reviews from cschuchardt88, nan01ab, and Jim8y via aedbc82 February 15, 2025 14:35

Merge branch 'master' into ec-recover-v2

76a968b

NGDAdmin approved these changes Feb 17, 2025

View reviewed changes

NGDAdmin merged commit f8f2cdb into master Feb 17, 2025
7 checks passed

NGDAdmin deleted the ec-recover-v2 branch February 17, 2025 02:24

mialbu mentioned this pull request Feb 17, 2025

[Neo 3.8] Add CryptoLib.recoverSecp256K1() neow3j/neow3j#1084

Closed

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2025

native: support CryptoLib's recoverSecp256K1 starting from Echidna

7ad4dc2

Port neo-project/neo#3696. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2025

native: support CryptoLib's recoverSecp256K1 starting from Echidna

6ea076b

Port neo-project/neo#3696. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

AnnaShaleva mentioned this pull request Apr 9, 2025

native: implement recoverSecp256K1 for CryptoLib nspcc-dev/neo-go#3863

Merged

AnnaShaleva added a commit to nspcc-dev/neo-go that referenced this pull request Apr 9, 2025

native: support CryptoLib's recoverSecp256K1 starting from Echidna

6455dfa

Port neo-project/neo#3696. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EC Recover#3696

EC Recover#3696
NGDAdmin merged 22 commits intomasterfrom
ec-recover-v2

shargon commented Jan 24, 2025

Uh oh!

Uh oh!

shargon commented Jan 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jim8y commented Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

shargon commented Jan 24, 2025

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

shargon commented Jan 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jim8y commented Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants