Skip to content

Revert "Fixed Props paths for *.csproj builds"#3352

Merged
NGDAdmin merged 1 commit intomasterfrom
revert-3320-fix/props-files
Jun 26, 2024
Merged

Revert "Fixed Props paths for *.csproj builds"#3352
NGDAdmin merged 1 commit intomasterfrom
revert-3320-fix/props-files

Conversation

@cschuchardt88
Copy link
Member

Reverts #3320

@shargon
Copy link
Member

shargon commented Jun 21, 2024

#3320 (comment) i see your finger down

@Jim8y
Copy link
Contributor

Jim8y commented Jun 21, 2024

need context and reason.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 21, 2024

Something with dotnet pack build targets. Works everywhere else but with nuget. I didn't test that. So we both right, cause there is a bug in NuGet.Build.Tasks.Pack.targets or its a feature. So the behavior is not consistent with other build targets. Doesn't update that path, and I think it's because we Importing the Directory.Build.props. I am no msbuild specialist.

Error message

C:\Program Files\dotnet\sdk\8.0.302\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,
5): error : Could not find a part of the path 'R:\github\cschuchardt88\neo\src\.neo'

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I later tested in the local PR (which I closed) and this did not had impact as well on the problem reported by @superboyiii

@NGDAdmin NGDAdmin merged commit 2d0395f into master Jun 26, 2024
@NGDAdmin NGDAdmin deleted the revert-3320-fix/props-files branch June 26, 2024 02:15
cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants