Skip to content

Fixed Props paths for *.csproj builds#3320

Merged
NGDAdmin merged 7 commits intoneo-project:masterfrom
cschuchardt88:fix/props-files
Jun 18, 2024
Merged

Fixed Props paths for *.csproj builds#3320
NGDAdmin merged 7 commits intoneo-project:masterfrom
cschuchardt88:fix/props-files

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jun 11, 2024 •
edited
Loading

Change Log

  • Changed from $(SolutionDir) to ../../

NOTE: for github actions and building from *.csproj files.

Fixes #3345

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 requested a review from a team June 11, 2024 02:43
@Jim8y
Copy link
Contributor

Jim8y commented Jun 11, 2024 •
edited
Loading

What is the problem with the original code?

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 11, 2024 •
edited
Loading

If you don't use a solution file. It will have wrong pathing.

$(SolutionDir) will be empty so path will be \.neo\neo.png

Example (linux)

dotnet pack ./srv/neo/neo.csproj

@Jim8y
Copy link
Contributor

Jim8y commented Jun 11, 2024

If you don't use a solution file. It will have wrong pathing.

Example (linux)

dotnet pack ./srv/neo/neo.csproj

May be post a few pic of before this pr and after this pr.

@Jim8y Jim8y requested a review from a team June 11, 2024 02:47
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 11, 2024

Same issue as that PR #3306 fixes

@cschuchardt88 cschuchardt88 mentioned this pull request Jun 11, 2024
Closed
6 tasks
@shargon
Copy link
Member

shargon commented Jun 11, 2024

But this doesn't work before, I remember

@vncoelho vncoelho mentioned this pull request Jun 11, 2024
Merged
@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jun 16, 2024 •
edited
Loading

But this doesn't work before, I remember

msbuild reads upwares to the working directory for *.props, In solution file or not.

This PR fixes the problems when using a *.csproj file, NOT a solution file (*.sln) for github workflows and linux/vscode users like @vncoelho

Didn't work before, because not enough ../../../../../ or too many last time.

@vncoelho
Copy link
Member

vncoelho commented Jun 16, 2024

But this doesn't work before, I remember

msbuild reads upwares to the working directory for *.props, In solution file or not.

This PR fixes the problems when using a *.csproj file, NOT a solution file (*.sln) for github workflows and linux/vscode users like @vncoelho

Didn't work before, because not enough ../../../../../ or too many last time.

Users like me are the same as devcontainer, everything I have is docker base.

shargon
shargon approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This previously failed, but it works, is good for me

@cschuchardt88 cschuchardt88 mentioned this pull request Jun 17, 2024
Closed
@superboyiii
Copy link
Member

superboyiii commented Jun 18, 2024

This works for me.

@NGDAdmin NGDAdmin merged commit 2bd2a45 into neo-project:master Jun 18, 2024
@superboyiii superboyiii mentioned this pull request Jun 18, 2024
Closed
@cschuchardt88 cschuchardt88 mentioned this pull request Jun 18, 2024
Closed
vncoelho added a commit that referenced this pull request Jun 18, 2024
@vncoelho
Revert "Fixed Props paths for *.csproj builds (#3320)"
2c4a4c6 
This reverts commit 2bd2a45.
cschuchardt88 added a commit that referenced this pull request Jun 21, 2024
@cschuchardt88
Revert "Fixed Props paths for *.csproj builds (#3320)"
5ff2c8f 
This reverts commit 2bd2a45.
@cschuchardt88 cschuchardt88 mentioned this pull request Jun 21, 2024
Merged
@cschuchardt88 cschuchardt88 deleted the fix/props-files branch June 24, 2024 05:40
NGDAdmin pushed a commit that referenced this pull request Jun 26, 2024
@cschuchardt88
Revert "Fixed Props paths for *.csproj builds (#3320)" (#3352)
2d0395f 
This reverts commit 2bd2a45.
cschuchardt88 added a commit to cschuchardt88/neo that referenced this pull request Jun 26, 2024
@cschuchardt88
Reapply "Fixed Props paths for *.csproj builds (neo-project#3320)" (n…
bd56d4c 
…eo-project#3352)

This reverts commit 2d0395f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

+1 more reviewer

@superboyiii superboyiii superboyiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to Merge Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong debug/release path of plugins

6 participants

@cschuchardt88 @Jim8y @shargon @vncoelho @superboyiii @NGDAdmin