Skip to content

Remove IsStandardContract#2400

Merged
erikzhang merged 2 commits intoneo-project:masterfrom
shargon:is-standard-contract-check
Mar 16, 2021
Merged

Remove IsStandardContract#2400
erikzhang merged 2 commits intoneo-project:masterfrom
shargon:is-standard-contract-check

Conversation

@shargon
Copy link
Member

@shargon shargon commented Mar 15, 2021

Close #2399

@shargon shargon requested a review from erikzhang March 15, 2021 11:51
@cloud8little
Copy link
Contributor

cloud8little commented Mar 16, 2021

Test when invokefunction with wallet open, since the wallet not sign, witness is null.

cacdc5861aa7c74323ccba31dfcec40

then send the transaction, check applicationlog, this time witness is not null.

e80fee4fe8cc0ea8fcf4b80c3ff12cf

@csmuller please have a check.

cloud8little
cloud8little previously approved these changes Mar 16, 2021
@superboyiii
Copy link
Member

@erikzhang Need your review.

@erikzhang
Copy link
Member

I think we can just remove the syscall IsStandardContract. It is useless now.

@superboyiii
Copy link
Member

superboyiii commented Mar 16, 2021

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

@shargon shargon changed the title Check tx.Witnesses null when check IsStandardContract Remove IsStandardContract Mar 16, 2021
@shargon
Copy link
Member Author

shargon commented Mar 16, 2021

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

No, @roman-khimov what do you think?

@roman-khimov
Copy link
Contributor

@shargon Do we have any scenario to call IsStandardContract? Seems it's impossible to do this in contract.

No, @roman-khimov what do you think?

#1753, option №4 wins.

@superboyiii
Copy link
Member

Merge?

@dusmart
Copy link

dusmart commented Apr 28, 2022

Please remove this syscall's price in document. Thanks.
https://docs.neo.org/docs/zh-cn/reference/fees.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

should check tx.Witnesses null when check IsStandardContract

7 participants