Add native contract: StdLib and CryptoLib#2298
Conversation
vncoelho
left a comment
There was a problem hiding this comment.
This is very good and waited change!
We from C++ love it.
|
If we move all to native contracts, we will need syscalls? |
|
We need syscall. Some syscalls can't be moved. |
|
Go? |
|
Test need neo-project/neo-node#740. |
|
We can merge first. |
|
I would like to move the UT, so please wait one day |
| { | ||
| try | ||
| { | ||
| return Crypto.VerifySignature(message, signature, pubkey, curves[curve]); |
There was a problem hiding this comment.
Maybe it will be faster with a switch?
There was a problem hiding this comment.
Maybe we will add more curves in the future.
|
I have problems with UT because Blockchain actor is loaded asynchronous. Any idea about how to wait until finish? |
TODO remove sleep
Why do you need to wait for blockchain actor? |
|
@erikzhang could you take a look to |
Because NativeContracts are not initialized and UT fault. |
Done. |
* neo-project/neo#2295 * neo-project/neo#2290 * neo-project/neo#2292 * neo-project/neo#2296 * neo-project/neo#2301 * neo-project/neo#2298 * neo-project/neo#2312 * neo-project/neo#2300 * neo-project/neo#2333 * neo-project/neo#2337 * neo-project/neo#2331 * neo-project/neo#2332 * neo-project/neo#2343 * neo-project/neo#2339 * neo-project/neo#2350 * neo-project/neo#2351 * neo-project/neo#2353 * neo-project/neo#2356 * neo-project/neo#2375 * neo-project/neo#2377 * neo-project/neo#2379 * https://github.com/neo-project/neo/pull/2392/files * neo-project/neo#2400 * audit updates * refactor and bump VM requirement
No description provided.