Neo Name Service by erikzhang · Pull Request #2201 · neo-project/neo

erikzhang · 2021-01-05T11:45:37Z

Close #1545
Replace #1644

erikzhang · 2021-01-05T17:49:26Z

Ready for review.

vncoelho · 2021-01-05T18:04:08Z

src/neo/SmartContract/Native/NameService.cs

+            uint now = (uint)(engine.Snapshot.PersistingBlock.Timestamp / 1000) + 1;
+            byte[] start = CreateStorageKey(Prefix_Expiration).AddBigEndian(0).ToArray();
+            byte[] end = CreateStorageKey(Prefix_Expiration).AddBigEndian(now).ToArray();
+            foreach (var (key, _) in engine.Snapshot.Storages.FindRange(start, end))


Maybe it is possible to just delete those expired within the last couple of seconds.
The start can be the last end.

There is no difference when doing db search.

doubiliu · 2021-01-07T06:20:26Z

src/neo/SmartContract/Native/NameService.cs

+                    if (!IPAddress.TryParse(data, out IPAddress address)) throw new FormatException();
+                    if (address.AddressFamily != AddressFamily.InterNetwork) throw new FormatException();
+                    break;
+                case RecordType.CNAME:


It is better to check whether the original domain name exists.

But the original name can be external.

what do you mean?

An external name, for example, google.com.

src/neo/SmartContract/Native/NameService.cs

cloud8little · 2021-01-12T11:44:44Z

Tested PASS with following scenaroes:

addRoot with committee members
addRoot with non-committee member
addRoot and register name, such as neo.org
register name with longer than 62 characters, Upper-Case, special characters.
setPrice and then register name, the price changed.
Two accounts can not register the same name
The same account can not register the same name twice.
Account A transfer the NNS token to another account, A not able to setRecord, the new account is able to setRecord. A not able to setAdmin, the new account is able to setRecord.
nns1 account register org.neo, add CNAME record onchain.com;
nns2 account register onchain.com; add CNAME record onchain.org,
nns3 account register onchain.org; add CNAME record leo.com,
nns4 account register leo.com； add IPV6 record "message",
resolve leo.com with IPV6 type，get "message"
resolve onchain.org with IPV6 type get "message"
resolve onchain.com的IPV6 type, get "message"
resolve org.neo with IPV6 record ；with FAULT result.
more scenaroes to be added.

erikzhang · 2021-01-12T12:02:14Z

@cloud8little The cases can be added to UT.

cloud8little · 2021-01-13T06:39:21Z

@cloud8little The cases can be added to UT.

Sure, @erikzhang what do you think of following two questions?

why do we check the admin witness when setAdmin(L149)? I think the owner can decide whom to be the administrator of the domain name, no need to check the admin account.

neo/src/neo/SmartContract/Native/NameService.cs

Lines 144 to 153 in a3d97bc

    
           private void SetAdmin(ApplicationEngine engine, string name, UInt160 admin) 
        
           { 
        
               if (!nameRegex.IsMatch(name)) throw new ArgumentException(null, nameof(name)); 
        
               string[] names = name.Split('.'); 
        
               if (names.Length != 2) throw new ArgumentException(null, nameof(name)); 
        
               if (admin != null && !engine.CheckWitnessInternal(admin)) throw new InvalidOperationException(); 
        
               NameState state = engine.Snapshot.Storages.GetAndChange(CreateStorageKey(Prefix_Token).Add(GetKey(Utility.StrictUTF8.GetBytes(name)))).GetInteroperable<NameState>(); 
        
               if (!engine.CheckWitnessInternal(state.Owner)) throw new InvalidOperationException(); 
        
               state.Admin = admin; 
        
           }

seems there is no API to find out who is the admin. properties only return the domain name, description, and expiration data.

{"name":"testown1.neo","description":"","expiration":1642052284}

Thought providing contract method or RPC API is both OK. because the owner of the domain can transfer the domain to the other account, and the new account may have no idea who is the admin.

erikzhang · 2021-01-13T06:44:58Z

Because it checks that it is a valid address.
If you are the owner, you know who is the administrator. If you are not, why do you want to know it? Maybe we should set the Admin to null automatically after transfer. What do you think?

cloud8little · 2021-01-13T06:54:28Z

Because it checks that it is a valid address.

If you are the owner, you know who is the administrator. If you are not, why do you want to know it? Maybe we should set the Admin to null automatically after transfer. What do you think?

1 is ok to me.
2. I think it is ok and reasonable to set the admin to null after transfer, then the old admin is not able to manipulate the domain name. It is up to the new account to reset the admin.

erikzhang · 2021-01-13T07:30:03Z

Please check #2222

…nEngine running again

Neo Name Service

4ffcb26

erikzhang added this to the NEO 3.0 milestone Jan 5, 2021

erikzhang added 6 commits January 5, 2021 20:33

Add RecordType

81a009a

Allow the committee to add root names

9aec758

Allow the committee to modify the price of domains

2a1c383

Expiration/Renew

22ee86f

SetAdmin

066e17f

Set, query, resolve

f0cb851

erikzhang marked this pull request as ready for review January 5, 2021 17:48

vncoelho reviewed Jan 5, 2021

View reviewed changes

erikzhang and others added 2 commits January 6, 2021 02:37

Delete record

cf2d3db

Merge branch 'master' into nns

0b1e95c

doubiliu reviewed Jan 7, 2021

View reviewed changes

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Show resolved Hide resolved

Add some test

c8abd3c

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Show resolved Hide resolved

shargon added 3 commits January 7, 2021 11:16

Add IsAvailable

020fc3f

Add isAvailable

63ae542

Add ExpireOn

b028495

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Show resolved Hide resolved

erikzhang commented Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Outdated Show resolved Hide resolved

shargon added 2 commits January 7, 2021 13:28

Remove expireOn

af5484a

Change owner or admin

7e1c8e7

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Outdated Show resolved Hide resolved

Remove renew check

cb2fa6f

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Show resolved Hide resolved

shargon added 3 commits January 7, 2021 14:11

Add more ut

51b5f1d

Reverted OR

04d5da3

More

820f5b4

shargon reviewed Jan 7, 2021

View reviewed changes

src/neo/SmartContract/Native/NameService.cs Outdated Show resolved Hide resolved

erikzhang and others added 3 commits January 7, 2021 22:35

CheckAdmin

ec41601

Merge branch 'master' into nns

73cc8b1

Fix merge

a638544

shargon approved these changes Jan 10, 2021

View reviewed changes

erikzhang merged commit b87df5d into master Jan 10, 2021

erikzhang deleted the nns branch January 10, 2021 11:05

roman-khimov mentioned this pull request Jan 12, 2021

Add NFT and NNS support nspcc-dev/neo-go#1662

Closed

Tommo-L mentioned this pull request Jan 13, 2021

Add NameService neo-project/neo-devpack-dotnet#421

Closed

superboyiii mentioned this pull request Jan 14, 2021

Preview5 Checklist #2171

Closed

36 tasks

cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021

Neo Name Service (neo-project#2201)

a5b4b07

ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 12, 2021

neo-project/neo#2201 and a bunch of other fixes to get the Applicatio…

412e04e

…nEngine running again

Conversation

erikzhang commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Jan 5, 2021

Uh oh!

vncoelho Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

erikzhang Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

doubiliu Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

erikzhang Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

doubiliu Jan 9, 2021

Choose a reason for hiding this comment

Uh oh!

erikzhang Jan 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cloud8little commented Jan 12, 2021

Uh oh!

erikzhang commented Jan 12, 2021

Uh oh!

cloud8little commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloud8little commented Jan 13, 2021

Uh oh!

erikzhang commented Jan 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erikzhang commented Jan 5, 2021 •

edited

Loading

cloud8little commented Jan 13, 2021 •

edited

Loading

erikzhang commented Jan 13, 2021 •

edited

Loading