Closed
Conversation
added 11 commits
May 22, 2020 15:51
doubiliu
commented
May 25, 2020
|
|
||
| ttl = parentDomainState.TimeToLive; | ||
| } | ||
| Mint(engine, account, tokenId, ttl); |
Contributor
Author
There was a problem hiding this comment.
We need check whether its parent domain is registered
Member
|
Could you ceate two PR, one for NEP11 and other for NS? |
Contributor
|
@doubiliu will help split it. |
Closed
Contributor
Author
|
Already split |
joeqian10
reviewed
Jun 4, 2020
| byte[] tokenId = args[0].GetSpan().ToArray(); | ||
| string name = Encoding.UTF8.GetString(tokenId).ToLower(); | ||
| string[] domains = name.Split("."); | ||
| if (domains.Length > 3) return false; // only the root and first-level name can be registered |
Contributor
There was a problem hiding this comment.
I think here should be if (domains.Length > 2) return false;.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1545 Pre-PR #1670 is required.
In this PR, we have completed an NNS implementation.
Where in the software does this update applies to?