Send Ping every minute?

Send Ping every minute?

We can update the values also when we receive a block

Just as a side note, the way we ping in neo-go is we're setting a node-wide timer for PingInterval (which by default is set twice SecondsPerBlock), when it fires we're checking if there were any new blocks added to the chain since previous timer expiration. If the chain has progressed, we're not doing anything. If not, then we're sending pings to all of our neighbors.

The rationale for this behavior is:

• pinging to check the connection doesn't improve things much as dead connection is usually quickly detected by broadcasts that happen quite frequently
• if we're receiving new blocks we shouldn't care much about the other node's height
• if we're not receiving blocks for some time, that's when we should worry a little and try to check with our peers if we're not missing anything
• per-peer timers don't make much sense with this usage pattern as the primary driver for ping requests here is the chain state
• pings are being sent to all peers for the same reason, we either need to confirm that everyone is at the same height with us and it's just the block being late, or we need to find some peer that's more up to date

@erikzhang please take a look again, we can reduce the ping intervals when we receive a block.