[neo2] Raise priority of Ping/Pong#1812
Merged
erikzhang merged 5 commits intoneo-project:master-2.xfrom Aug 10, 2020
Merged
Conversation
vncoelho
previously approved these changes
Jul 31, 2020
Member
vncoelho
left a comment
There was a problem hiding this comment.
Very good efforts. We need to port this to NEO 3 later.
Tommo-L
reviewed
Jul 31, 2020
neo/Network/P2P/TaskManager.cs
Outdated
| return Akka.Actor.Props.Create(() => new TaskManager(system)).WithMailbox("task-manager-mailbox"); | ||
| } | ||
|
|
||
| private readonly ConcurrentDictionary<ActorPath, DateTime> _expiredTimes = new ConcurrentDictionary<ActorPath, DateTime>(); |
Contributor
There was a problem hiding this comment.
Dictionary<ActorPath, DateTime> is enough?
Contributor
Author
There was a problem hiding this comment.
Dictionary<ActorPath, DateTime> is not thread-safe, may cause insert error in concurrent scenarios.
shargon
reviewed
Aug 3, 2020
Member
shargon
left a comment
There was a problem hiding this comment.
We need a mechanism for cleaning _expiredTimes
Contributor
Author
|
Maybe add a |
Member
|
yes, a task it's good, something to prevent an |
shargon
previously approved these changes
Aug 4, 2020
Member
|
@Ashuaidehao please take a look to my solution for neo3 without a new collection. #1829 I think that we can do the same here |
Member
|
Sorry for close, miss click |
Member
|
@shargon Test PASS, is able to merge. (from BSN side, the issue provider, they work well after this PR till now) |
superboyiii
previously approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise priority of Ping/Pong to ensure the reliability of syncing blocks process，Close #1806.