Generate loop for toString() on Struct member arrays#690
Merged
Conversation
bocchino
reviewed
May 7, 2025
bocchino
reviewed
May 7, 2025
Collaborator
bocchino
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of comments.
af649bb to
baff224
Compare
bocchino
reviewed
May 8, 2025
compiler/lib/src/main/scala/codegen/CppWriter/StructCppWriter.scala
Outdated
Show resolved
Hide resolved
Collaborator
|
I confirmed that the check-cpp and FppTest tests pass. |
LeStarch
added a commit
to LeStarch/fpp
that referenced
this pull request
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up
toString()for struct member arrays by concatenating a string to format the array. I ran FppTest in addition to our normal testing to validate the toString() formatting still matches.Closes #689