Skip to content

Backport of PR #690 to v2.3.0#692

Merged
bocchino merged 4 commits intonasa:release/v2.3.1from
LeStarch:backport/v2.3.0-#690
May 8, 2025
Merged

Backport of PR #690 to v2.3.0#692
bocchino merged 4 commits intonasa:release/v2.3.1from
LeStarch:backport/v2.3.0-#690

Conversation

@LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented May 8, 2025

This is a backport of the change made in #690 to work with v2.3.0 version of FPP.

@LeStarch LeStarch requested review from Kronos3 and bocchino May 8, 2025 19:39
Copy link
Collaborator

@Kronos3 Kronos3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I should delete my branch for this :) https://github.com/nasa/fpp/tree/tumbar-struct-member-array-loop-backport

@LeStarch
Copy link
Collaborator Author

LeStarch commented May 8, 2025

@Kronos3 sorry I didn't know you were in the process of backporting. I just cranked through the changes once the process was greenlit.

Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino
Copy link
Collaborator

bocchino commented May 8, 2025

I confirmed that check-cpp passes and FppTest passes in F Prime v3.6.2. Note that because of build system issues that we fixed after v3.6.2, there are some warnings when compiling FppTest with the latest version of clang. The warnings don't halt the build because -Werror is not enabled.

@bocchino bocchino merged commit 46d0796 into nasa:release/v2.3.1 May 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants