More removal of np.all(... == ...)#6238
Merged
andy-sweet merged 3 commits intonapari:mainfrom Sep 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6238 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 583 583
Lines 51364 51364
=======================================
+ Hits 47051 47054 +3
+ Misses 4313 4310 -3
|
andy-sweet
approved these changes
Sep 19, 2023
Member
andy-sweet
left a comment
There was a problem hiding this comment.
Thanks! I left a comment on the related issue, but this looks good regardless, as it will fix issues with empty arrays.
Czaki
approved these changes
Sep 19, 2023
Collaborator
Czaki
left a comment
There was a problem hiding this comment.
Looks good, but Andy's suggestion may be a good approach for future ones.
Contributor
Author
Yes, it should be straitforward once we bump the min version to do bulk replace. |
Carreau
added a commit
to Carreau/napari
that referenced
this pull request
Sep 20, 2023
As discussed in napari#6238 and napari#6126. This will conflict with the former one once merged but is easy to rebase and do en-masse anyway. The error messages are no as-nice with numpy below 1.24, but still enough to see the differences.
kne42
added a commit
to kne42/napari
that referenced
this pull request
Sep 21, 2023
* main: Move `test_file_menu.py` to new app model location (napari#6233) Add toggle status view menu items (napari#6137) More removal of np.all(... == ...) (napari#6238) [pre-commit.ci] pre-commit autoupdate (napari#6229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6126
This is in general stricter, more correct and in some case faster.