Skip to content

Move test_file_menu.py to new app model location#6233

Merged
DragaDoncila merged 2 commits intonapari:mainfrom
lucyleeow:mv_file_test
Sep 20, 2023
Merged

Move test_file_menu.py to new app model location#6233
DragaDoncila merged 2 commits intonapari:mainfrom
lucyleeow:mv_file_test

Conversation

@lucyleeow
Copy link
Copy Markdown
Contributor

@lucyleeow lucyleeow commented Sep 19, 2023

Reference: #4865 (comment)

Move test_file_menu.py to new app model location, as file_menu no longer exists in napari/_qt/menus and this folder is scheduled to be removed as we move to app model.

@lucyleeow
Copy link
Copy Markdown
Contributor Author

cc @DragaDoncila

@github-actions github-actions bot added tests Something related to our tests qt Relates to qt labels Sep 19, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6233 (99f5b28) into main (eaff277) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6233   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         583      583           
  Lines       51364    51364           
=======================================
+ Hits        47051    47054    +3     
+ Misses       4313     4310    -3     
Files Changed Coverage Δ
napari/_qt/_qapp_model/_tests/test_file_menu.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Copy Markdown
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following this up @lucyleeow!

@DragaDoncila DragaDoncila added the ready to merge Last chance for comments! Will be merged in ~24h label Sep 19, 2023
@Carreau Carreau added this to the 0.5 milestone Sep 19, 2023
@Carreau Carreau added the maintenance PR with maintance changes, label Sep 19, 2023
@Czaki Czaki modified the milestones: 0.5, 0.5.0 Sep 19, 2023
@DragaDoncila DragaDoncila merged commit 3549323 into napari:main Sep 20, 2023
@lucyleeow lucyleeow deleted the mv_file_test branch September 21, 2023 02:24
kne42 added a commit to kne42/napari that referenced this pull request Sep 21, 2023
* main:
  Move `test_file_menu.py` to new app model location (napari#6233)
  Add toggle status view menu items (napari#6137)
  More removal of np.all(... == ...) (napari#6238)
  [pre-commit.ci] pre-commit autoupdate (napari#6229)
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PR with maintance changes, qt Relates to qt tests Something related to our tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants