Skip to content

Test vectors#396

Merged
sofroniewn merged 2 commits intonapari:masterfrom
sofroniewn:test_vectors
Jul 9, 2019
Merged

Test vectors#396
sofroniewn merged 2 commits intonapari:masterfrom
sofroniewn:test_vectors

Conversation

@sofroniewn
Copy link
Copy Markdown
Contributor

Description

This PR adds tests for the vectors layer, improves the doc strings and cleans up the code a tiny bit, but doesn't change any functionality.

One question is - should the input parameters be
edge_width, edge_color, and length for the width, color, and the multiplicative length factor for the vectors or should they be something else. They used to just be width, color, and length but I added edge_ to make the parameters the same as for the points and shapes layer, though you could argue that for the points layer the parameters do different things and that in the vectors layer we don't have a face and an edge so it is just confusing. I'm open to suggestions - personally I like the consistency - but we can change it. Thoughts @bryantChhun @kevinyamauchi @jni?

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

How has this been tested?

  • adds napari/layers/vectors/tests/test_vectors.py

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sofroniewn sofroniewn added refactor Refactoring code base tests Something related to our tests labels Jul 8, 2019
@sofroniewn sofroniewn added this to the 0.1.0 milestone Jul 8, 2019
@sofroniewn sofroniewn requested a review from a team July 8, 2019 16:57
Copy link
Copy Markdown

@AhmetCanSolak AhmetCanSolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is working as expected and to me looks good.

@bryantChhun
Copy link
Copy Markdown
Contributor

I'm ok with "edge_". It's clear enough to me that this shape isn't exactly like the others.

@sofroniewn sofroniewn merged commit 5778d33 into napari:master Jul 9, 2019
DragaDoncila pushed a commit that referenced this pull request Apr 11, 2024
# References and relevant issues
closes #396

Forgot to delete in #6767

Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring code base tests Something related to our tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants