Merged
Conversation
AhmetCanSolak
approved these changes
Jul 9, 2019
AhmetCanSolak
left a comment
There was a problem hiding this comment.
it is working as expected and to me looks good.
Contributor
|
I'm ok with "edge_". It's clear enough to me that this shape isn't exactly like the others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for the vectors layer, improves the doc strings and cleans up the code a tiny bit, but doesn't change any functionality.
One question is - should the input parameters be
edge_width,edge_color, andlengthfor the width, color, and the multiplicative length factor for the vectors or should they be something else. They used to just bewidth,color, andlengthbut I addededge_to make the parameters the same as for thepointsandshapeslayer, though you could argue that for thepointslayer the parameters do different things and that in the vectors layer we don't have afaceand anedgeso it is just confusing. I'm open to suggestions - personally I like the consistency - but we can change it. Thoughts @bryantChhun @kevinyamauchi @jni?Type of change
How has this been tested?
napari/layers/vectors/tests/test_vectors.pyFinal checklist: