Skip to content

Remove redundant _view_actions.py#6821

Merged
DragaDoncila merged 3 commits intonapari:mainfrom
lucyleeow:rm_view
Apr 11, 2024
Merged

Remove redundant _view_actions.py#6821
DragaDoncila merged 3 commits intonapari:mainfrom
lucyleeow:rm_view

Conversation

@lucyleeow
Copy link
Copy Markdown
Contributor

References and relevant issues

closes #396

Forgot to delete in #6767

@lucyleeow lucyleeow added the bugfix PR with bugfix label Apr 9, 2024
Copy link
Copy Markdown
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow! Idk what's up with coverage...

@brisvag
Copy link
Copy Markdown
Contributor

brisvag commented Apr 10, 2024

coverage's broken, getting fixed in #6701!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (f9773db) to head (698ae27).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6821      +/-   ##
==========================================
- Coverage   92.42%   92.39%   -0.04%     
==========================================
  Files         615      614       -1     
  Lines       54918    54904      -14     
==========================================
- Hits        50758    50728      -30     
- Misses       4160     4176      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brisvag brisvag added this to the 0.5.0 milestone Apr 11, 2024
@brisvag brisvag added the ready to merge Last chance for comments! Will be merged in ~24h label Apr 11, 2024
@DragaDoncila DragaDoncila merged commit 2d2cac6 into napari:main Apr 11, 2024
@DragaDoncila DragaDoncila removed the ready to merge Last chance for comments! Will be merged in ~24h label Apr 11, 2024
@lucyleeow lucyleeow deleted the rm_view branch April 11, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR with bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants