Skip to content

fixed match function to be non-regex#2

Merged
mwichmann merged 1 commit into
mwichmann:depr-Copyfrom
bdbaddog:fix_test_issue_mwichmann_copy_method
Dec 14, 2019
Merged

fixed match function to be non-regex#2
mwichmann merged 1 commit into
mwichmann:depr-Copyfrom
bdbaddog:fix_test_issue_mwichmann_copy_method

Conversation

@bdbaddog

Copy link
Copy Markdown

merge me?

@mwichmann mwichmann merged commit cde8e86 into mwichmann:depr-Copy Dec 14, 2019
mwichmann pushed a commit that referenced this pull request Oct 14, 2020
The way runtest.py passes the list of fixture directories is racy because it
sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting
on Python to start the subprocess before that list is overwritten when spawning
the next directory. At least on Windows, the environment is not copied in
subprocess.run so runtest.py may overwrite the list of fixture directories
with the list for test #2 while the subprocess module is still kicking off
test #1. I was able to easily reproduce this by running the command:
`python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py`
a few times in a row. However, with this fix, that command repeatedly succeeds.

To validate ths fix, I also ran that command with "--xml a.xml" and
"--xml a.xml --nopipefiles" to validate that those other executors worked
correctly.
mwichmann pushed a commit that referenced this pull request Apr 13, 2021
Fix failing tests, restore last ditch default setting in TempFileMunge for TEMPFILEARGESCFUNC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants