Skip to content

changes to unit test to avoid hitting the filesystem#1

Merged
mwichmann merged 1 commit into
mwichmann:java-versfrom
bdbaddog:java-vers
Apr 22, 2019
Merged

changes to unit test to avoid hitting the filesystem#1
mwichmann merged 1 commit into
mwichmann:java-versfrom
bdbaddog:java-vers

Conversation

@bdbaddog

Copy link
Copy Markdown

No description provided.

if self.outer_state.localClasses and \
self.outer_state.stackBrackets[-1] > \
self.outer_state.stackBrackets[-2]+1:
self.outer_state.stackBrackets[-1] > \

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe parens here to group the "a > b" part would make it more readable? and eliminate the need for that backslash-line-continuation

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does pylint think of such? ;)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reaction one way or the other. . Has plenty of other things to say, though... included just for grins:

JavaCommon-lint.txt

@mwichmann mwichmann merged commit faa7782 into mwichmann:java-vers Apr 22, 2019
bdbaddog pushed a commit that referenced this pull request Feb 21, 2020
This change adds support for scanning multiple entries in an action string in
order to better support the following use cases:

1. A file is provided in an action string and should be taken as a dependency.
   For example, an action string "$PERL somefile.pl".
2. An action string actually has two actions separated by &&. For example,
   "cd <some_dir> && $ZIP <args>".

Adding support for #1 actually allows us to fix the test
IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a
Python file as executable even on Windows. This was causing tests to repeatedly
open the default handler of Python files, which if set to Visual Studio causes
DDE hangs. This test is fixed because now we can have the action string specify
python as the first command and still take an implicit dependency on the
script, which is now the second command.
mwichmann pushed a commit that referenced this pull request Oct 14, 2020
The way runtest.py passes the list of fixture directories is racy because it
sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting
on Python to start the subprocess before that list is overwritten when spawning
the next directory. At least on Windows, the environment is not copied in
subprocess.run so runtest.py may overwrite the list of fixture directories
with the list for test #2 while the subprocess module is still kicking off
test #1. I was able to easily reproduce this by running the command:
`python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py`
a few times in a row. However, with this fix, that command repeatedly succeeds.

To validate ths fix, I also ran that command with "--xml a.xml" and
"--xml a.xml --nopipefiles" to validate that those other executors worked
correctly.
mwichmann pushed a commit that referenced this pull request Apr 13, 2021
mwichmann pushed a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants