feat: early support for arrays#341
Merged
baszalmstra merged 52 commits intomun-lang:mainfrom Dec 8, 2022
Merged
Conversation
11 tasks
7f0db17 to
52c7f15
Compare
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 87.16% 87.09% -0.07%
==========================================
Files 271 275 +4
Lines 29356 31046 +1690
==========================================
+ Hits 25588 27040 +1452
- Misses 3768 4006 +238
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
52c7f15 to
0f5d148
Compare
Collaborator
Author
|
I would really like to support creating arrays from a Rust iterator. Something like: let mun_array: ArrayRef = runtime.construct_array::<i32>(vec![1,2,3,4,].into_iter())However, this requires type references, because the type information of the array cannot be created. The type information has to be created and shared with the mun libraries. This requires type references. |
7d35a1b to
6b9420c
Compare
6b9420c to
35ddadc
Compare
6d1839d to
bbe485b
Compare
Collaborator
Author
|
Depends on #268 |
18 tasks
bbe485b to
56e7249
Compare
85125a1 to
8abd1b7
Compare
feat: array memory mapping
Collaborator
|
For the rocket and spaceship logic, can all of tr updates not just happen in Mun? In theory, we only need to query their positions from Rust to draw them |
docs: add book chapter about arrays
Wodann
approved these changes
Dec 8, 2022
baszalmstra
added a commit
that referenced
this pull request
Dec 8, 2022
Adds early support for arrays in Mun! Co-authored-by: Wodann <Wodann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for arrays.
Missing feature:
Out of scope