feat: array memory mapping#20
Merged
baszalmstra merged 28 commits intobaszalmstra:feature/arraysfrom Nov 13, 2022
Merged
Conversation
baszalmstra
reviewed
Aug 6, 2022
…factor/memory-mapping
3 tasks
baszalmstra
requested changes
Aug 27, 2022
Owner
baszalmstra
left a comment
There was a problem hiding this comment.
This already looks so much cleaner than the previous implementation. Great job!
| pub struct Foo { | ||
| a: i32, | ||
| b: [Bar], | ||
| c: [Baz], |
| ); | ||
| } | ||
|
|
||
| #[test] |
Owner
There was a problem hiding this comment.
All of these tests, test if the value of a certain instance has not changed. However, this is done through get which also performs casting if possible. I think besides testing whether or not the content changes, it should also test whether or not the type actually changes.
Owner
There was a problem hiding this comment.
The tests also feel very verbose to me. Although its a good thing because they thoroughly test the code it also makes them much harder to maintain if we change details down the line. Im wondering if its possible to reduce the number of lines required to setup a test like this... Its just a thought.
…-lang#447) Updates the requirements on ra_ap_text_edit to permit the latest version. --- updated-dependencies: - dependency-name: ra_ap_text_edit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-lang#449) Updates the requirements on ra_ap_text_edit to permit the latest version. --- updated-dependencies: - dependency-name: ra_ap_text_edit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.0...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [lockfile](https://github.com/derekdreery/lockfile-rs) to permit the latest version. - [Release notes](https://github.com/derekdreery/lockfile-rs/releases) - [Changelog](https://github.com/derekdreery/lockfile-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/derekdreery/lockfile-rs/commits) --- updated-dependencies: - dependency-name: lockfile dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-lang#451) Updates the requirements on ra_ap_text_edit to permit the latest version. --- updated-dependencies: - dependency-name: ra_ap_text_edit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-lang#460) Updates the requirements on ra_ap_text_edit to permit the latest version. --- updated-dependencies: - dependency-name: ra_ap_text_edit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-lang#473) Updates the requirements on ra_ap_text_edit to permit the latest version. --- updated-dependencies: - dependency-name: ra_ap_text_edit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
baszalmstra
approved these changes
Nov 6, 2022
| used_deletions | ||
| .into_iter() | ||
| .zip(deletions.into_iter()) | ||
| .for_each(|(used, (_, old_index, ty, _))| { |
Owner
There was a problem hiding this comment.
Same here, I would write this as a regular for statement.
Author
There was a problem hiding this comment.
I actually like these as you're already explicitly working with zipped iterators. I changed the other one
| used_insertions | ||
| .into_iter() | ||
| .zip(insertions.into_iter()) | ||
| .for_each(|(used, (_, new_index, ty, _))| { |
Author
There was a problem hiding this comment.
Also didn't resolve for same reason as above comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a clearer separation between the calculation of a memory mapping and the execution thereof. Also, adds support for array memory mapping.
Supported array mappings (recursively) are:
[f64] <-> f64 (array from/to primitive + valid casts)
[f32] <-> [[f64]] (array from/to primitive + valid casts)
[Foo] <-> Foo (array from/to struct + struct mapping)